Skip to content
Permalink
Browse files

Address PR review comments

  • Loading branch information
elpaso committed Jul 16, 2020
1 parent 4192797 commit f4ccbf29528988aae1643ce18ecb2808a925c7c7
@@ -41,6 +41,7 @@ class QgsNewVectorTableFieldModel;
* The actual creation of the table is delegated to the connections API method
* QgsAbstractDatabaseProviderConnection::createVectorTable()
*
* \ingroup gui
* \since QGIS 3.16
*/
class GUI_EXPORT QgsNewVectorTableDialog : public QDialog, private Ui_QgsNewVectorTableDialogBase
@@ -60,7 +60,7 @@ void QgsMssqlDataItemGuiProvider::populateContextMenu( QgsDataItem *item, QMenu
connect( actionShowNoGeom, &QAction::toggled, connItem, &QgsMssqlConnectionItem::setAllowGeometrylessTables );
menu->addAction( actionShowNoGeom );

QAction *actionCreateSchema = new QAction( tr( "Create Schema…" ), menu );
QAction *actionCreateSchema = new QAction( tr( "New Schema…" ), menu );
connect( actionCreateSchema, &QAction::triggered, this, [connItem] { createSchema( connItem ); } );
menu->addAction( actionCreateSchema );
}
@@ -52,7 +52,7 @@ void QgsPostgresDataItemGuiProvider::populateContextMenu( QgsDataItem *item, QMe

menu->addSeparator();

QAction *actionCreateSchema = new QAction( tr( "Create Schema…" ), this );
QAction *actionCreateSchema = new QAction( tr( "New Schema…" ), this );
connect( actionCreateSchema, &QAction::triggered, this, [connItem] { createSchema( connItem ); } );
menu->addAction( actionCreateSchema );

@@ -226,7 +226,7 @@ void QgsPostgresDataItemGuiProvider::createSchema( QgsDataItem *item )
QgsPostgresConn *conn = QgsPostgresConn::connectDb( uri.connectionInfo( false ), false );
if ( !conn )
{
QMessageBox::warning( nullptr, tr( "Create Schema" ), tr( "Unable to create schema." ) );
QMessageBox::warning( nullptr, tr( "New Schema" ), tr( "Unable to create schema." ) );
return;
}

@@ -236,7 +236,7 @@ void QgsPostgresDataItemGuiProvider::createSchema( QgsDataItem *item )
QgsPostgresResult result( conn->PQexec( sql ) );
if ( result.PQresultStatus() != PGRES_COMMAND_OK )
{
QMessageBox::warning( nullptr, tr( "Create Schema" ), tr( "Unable to create schema %1\n%2" ).arg( schemaName,
QMessageBox::warning( nullptr, tr( "New Schema" ), tr( "Unable to create schema %1\n%2" ).arg( schemaName,
result.PQresultErrorMessage() ) );
conn->unref();
return;
@@ -9,7 +9,7 @@
<rect>
<x>0</x>
<y>0</y>
<width>924</width>
<width>936</width>
<height>562</height>
</rect>
</property>
@@ -244,7 +244,7 @@
<item>
<widget class="QPushButton" name="mAddFieldBtn">
<property name="text">
<string>Add field</string>
<string>Add Field</string>
</property>
<property name="icon">
<iconset resource="../../images/images.qrc">

0 comments on commit f4ccbf2

Please sign in to comment.
You can’t perform that action at this time.