Address PR review comments

qgis · Jul 16, 2020 · f4ccbf2 · f4ccbf2
1 parent 4192797
commit f4ccbf2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/src/gui/qgsnewvectortabledialog.h b/src/gui/qgsnewvectortabledialog.h
@@ -41,6 +41,7 @@ class QgsNewVectorTableFieldModel;
  * The actual creation of the table is delegated to the connections API method
  * QgsAbstractDatabaseProviderConnection::createVectorTable()
  *
+ * \ingroup gui
  * \since QGIS 3.16
  */
 class GUI_EXPORT QgsNewVectorTableDialog : public QDialog, private Ui_QgsNewVectorTableDialogBase

diff --git a/src/providers/mssql/qgsmssqldataitemguiprovider.cpp b/src/providers/mssql/qgsmssqldataitemguiprovider.cpp
@@ -60,7 +60,7 @@ void QgsMssqlDataItemGuiProvider::populateContextMenu( QgsDataItem *item, QMenu
     connect( actionShowNoGeom, &QAction::toggled, connItem, &QgsMssqlConnectionItem::setAllowGeometrylessTables );
     menu->addAction( actionShowNoGeom );
 
-    QAction *actionCreateSchema = new QAction( tr( "Create Schema…" ), menu );
+    QAction *actionCreateSchema = new QAction( tr( "New Schema…" ), menu );
     connect( actionCreateSchema, &QAction::triggered, this, [connItem] { createSchema( connItem ); } );
     menu->addAction( actionCreateSchema );
   }

diff --git a/src/providers/postgres/qgspostgresdataitemguiprovider.cpp b/src/providers/postgres/qgspostgresdataitemguiprovider.cpp
@@ -52,7 +52,7 @@ void QgsPostgresDataItemGuiProvider::populateContextMenu( QgsDataItem *item, QMe
 
     menu->addSeparator();
 
-    QAction *actionCreateSchema = new QAction( tr( "Create Schema…" ), this );
+    QAction *actionCreateSchema = new QAction( tr( "New Schema…" ), this );
     connect( actionCreateSchema, &QAction::triggered, this, [connItem] { createSchema( connItem ); } );
     menu->addAction( actionCreateSchema );
 
@@ -226,7 +226,7 @@ void QgsPostgresDataItemGuiProvider::createSchema( QgsDataItem *item )
   QgsPostgresConn *conn = QgsPostgresConn::connectDb( uri.connectionInfo( false ), false );
   if ( !conn )
   {
-    QMessageBox::warning( nullptr, tr( "Create Schema" ), tr( "Unable to create schema." ) );
+    QMessageBox::warning( nullptr, tr( "New Schema" ), tr( "Unable to create schema." ) );
     return;
   }
 
@@ -236,7 +236,7 @@ void QgsPostgresDataItemGuiProvider::createSchema( QgsDataItem *item )
   QgsPostgresResult result( conn->PQexec( sql ) );
   if ( result.PQresultStatus() != PGRES_COMMAND_OK )
   {
-    QMessageBox::warning( nullptr, tr( "Create Schema" ), tr( "Unable to create schema %1\n%2" ).arg( schemaName,
+    QMessageBox::warning( nullptr, tr( "New Schema" ), tr( "Unable to create schema %1\n%2" ).arg( schemaName,
                           result.PQresultErrorMessage() ) );
     conn->unref();
     return;

diff --git a/src/ui/qgsnewvectortabledialogbase.ui b/src/ui/qgsnewvectortabledialogbase.ui
@@ -9,7 +9,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>924</width>
+    <width>936</width>
     <height>562</height>
    </rect>
   </property>
@@ -244,7 +244,7 @@
      <item>
       <widget class="QPushButton" name="mAddFieldBtn">
        <property name="text">
-        <string>Add field</string>
+        <string>Add Field</string>
        </property>
        <property name="icon">
         <iconset resource="../../images/images.qrc">