crash when creating new GRASS location on Windows #11104

qgib · 2008-04-16T07:56:38Z

Author Name: Redmine Admin (Redmine Admin)
Original Redmine Issue: 1044

Redmine category:grass
Assignee: Tom Elwertowski

QGIS (Windows version only) crashes if you are trying to create location with almost same name as exist (the only difference is character case).

Steps to reproduce:

Create new GRASS location with name "bug"
Now try to create another GRASS location with name "Bug"
After last wizard step the QGIS crashes

The problem is that Linux is case sensitive (bug and Bug are two different strings) but in Windows there is impossible to create two files named "bug" and "Bug".

qgib · 2008-05-20T23:41:07Z

Author Name: Marco Pasetti - (Marco Pasetti -)

I think that the only possible solution is to introduce a name check to prevent this error, telling that the location Bug already exists and repromp for a new name.

Marco

qgib · 2008-07-16T04:47:01Z

Author Name: Maciej Sieczka - (Maciej Sieczka -)

Bug confirmed under WINE 1.0.0 configured to emulate Win XP, on amd64 Debian testing using Marco's "QGIS 0.11.0 for Windows pre-release testing installer".

Indeed it seems the culprit is Windows is not case-sensitive as GNU/Linux is.

qgib · 2008-07-17T23:56:30Z

Author Name: Marco Pasetti - (Marco Pasetti -)

Replying to [comment:4 msieczka]:

Bug confirmed under WINE 1.0.0 configured to emulate Win XP, on amd64 Debian testing using Marco's "QGIS 0.11.0 for Windows pre-release testing installer".

Indeed it seems the culprit is Windows is not case-sensitive as GNU/Linux is.

Absolutely! Windows is NOT case sensitive. As I said two months ago, there would be a simple solution: introduce a name check function to prevent this error, checking if the location's name (that is the folder) already exixts and, if yes, telling that the location Bug already exists and reprompt for a new name.

I donn't know if that should be done in GRASS code; actually I think that we could do that in one of the src\qgis-dev\src\plugins\grass\ cpp files

Jurgen?

qgib · 2008-09-09T06:15:44Z

Author Name: Tom Elwertowski (Tom Elwertowski)

This also happens on a Mac.

There's already a duplicate name check in qgsgrassnewmapset.cpp. It needs to be made case insensitive for Mac and Win.

qgib · 2008-09-09T12:18:30Z

Author Name: Tom Elwertowski (Tom Elwertowski)

Fixed by 47dbaf2 (SVN r9288).

resolution was changed from to fixed
status_id was changed from Open to Closed

qgib · 2008-09-10T06:52:52Z

Author Name: cgsbob - (cgsbob -)

Replying to [comment:7 telwertowski]:

Fixed by 47dbaf2 (SVN r9288).
I think there is a problem with 47dbaf2 (SVN r9288). I'm running qt4.4 and I get this compile error:

Scanning dependencies of target grassplugin
[ 87%] Building CXX object src/plugins/grass/CMakeFiles/grassplugin.dir/qgsgrassplugin.o
In file included from /home/bobm/src/gis/qgis_svn/src/plugins/grass/qgsgrassplugin.cpp:18:
/home/bobm/src/gis/qgis_svn/src/plugins/grass/qgsgrassplugin.h:99: error: &#17030;QPainter&#17031; has not been declared
/home/bobm/src/gis/qgis_svn/src/plugins/grass/qgsgrassplugin.cpp:523: error: prototype for &#17030;void [[QgsGrassPlugin]]::postRender(QPainter*)&#17031; does not match any in class &#17030;QgsGrassPlugin&#17031;
/home/bobm/src/gis/qgis_svn/src/plugins/grass/qgsgrassplugin.h:99: error: candidate is: void [[QgsGrassPlugin]]::postRender(int*)
maker2: *** [src/plugins/grass/CMakeFiles/grassplugin.dir/qgsgrassplugin.o] Error 1
maker1: *** [src/plugins/grass/CMakeFiles/grassplugin.dir/all] Error 2
make: *** [all] Error 2

The complete compiler output can be found here: [http://rafb.net/p/SAY4QJ37.html]

resolution was changed from fixed to
status_id was changed from Closed to Feedback

qgib · 2008-09-10T08:19:35Z

Author Name: Maciej Sieczka - (Maciej Sieczka -)

And I get a foloowing error in 98c3309 (SVN r9291):

[ 91%] Generating ui_qgsprojectionselectorbase.h
/home/shoofi/src/straight/qgis-trunk/src/ui/qgsprojectionselectorbase.ui: An invalid icon property 'windowIcon' was encountered.
Scanning dependencies of target grassplugin
[ 92%] Building CXX object src/plugins/grass/CMakeFiles/grassplugin.dir/qgsgrassplugin.o
In file included from /home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassplugin.cpp:18:
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassplugin.h:99: error: 'QPainter' has not been declared
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassplugin.cpp:523: error: prototype for 'void [[QgsGrassPlugin]]::postRender(QPainter*)' does not match any in class 'QgsGrassPlugin'
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassplugin.h:99: error: candidate is: void [[QgsGrassPlugin]]::postRender(int*)
maker2: *** [src/plugins/grass/CMakeFiles/grassplugin.dir/qgsgrassplugin.o] Error 1
maker1: *** [src/plugins/grass/CMakeFiles/grassplugin.dir/all] Error 2
make: *** [all] Error 2

qgib · 2008-09-10T08:28:35Z

Author Name: Tom Elwertowski (Tom Elwertowski)

These last two items were caused by 034dd53 (SVN r9289) which upgraded the plugin from Qt3 to Qt4. X11 needed a QPainter declaration that Mac did not. Fixed by 2624cde (SVN r9292).

status_id was changed from Feedback to Open

qgib · 2008-09-10T08:38:38Z

Author Name: Tom Elwertowski (Tom Elwertowski)

resolution was changed from to fixed
status_id was changed from Open to Closed

qgib · 2008-09-10T09:12:05Z

Author Name: Maciej Sieczka - (Maciej Sieczka -)

Yet another error, in 2624cde (SVN r9292):

[ 92%] Building CXX object src/plugins/grass/CMakeFiles/grassplugin.dir/qgsgrassmodel.o
[ 93%] Building CXX object src/plugins/grass/CMakeFiles/grassplugin.dir/qgsgrassmapcalc.o
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp: In member function 'virtual void [[QgsGrassMapcalc]]::mousePressEvent(QMouseEvent*)':
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:278: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:278: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:288: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:288: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp: In member function 'virtual QStringList [[QgsGrassMapcalc]]::checkRegion()':
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:494: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:494: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp: In member function 'virtual bool [[QgsGrassMapcalc]]::inputRegion(Cell_head*, bool)':
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:549: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:549: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp: In member function 'void [[QgsGrassMapcalc]]::growCanvas(int, int, int, int)':
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:957: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:957: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:965: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:965: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp: In member function 'void [[QgsGrassMapcalc]]::save()':
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:1124: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:1124: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:1175: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:1175: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp: In member function 'bool [[QgsGrassMapcalcConnector]]::tryConnectEnd(int)':
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:1990: error: must #include <typeinfo> before using typeid
/home/shoofi/src/straight/qgis-trunk/src/plugins/grass/qgsgrassmapcalc.cpp:1990: error: must #include <typeinfo> before using typeid
maker2: *** [src/plugins/grass/CMakeFiles/grassplugin.dir/qgsgrassmapcalc.o] Error 1
maker1: *** [src/plugins/grass/CMakeFiles/grassplugin.dir/all] Error 2
make: *** [all] Error 2

status_id was changed from Closed to Feedback
resolution was changed from fixed to

qgib · 2008-09-10T09:54:35Z

Author Name: Tom Elwertowski (Tom Elwertowski)

Add the line

#include

after #include <math.h> and try compiling again. I will wait for any other issues before updating svn.

What OS are you using? I will also add a comment that this file is needed for a particular OS so it doesn't get removed again.

status_id was changed from Feedback to Open

qgib · 2008-09-10T21:20:56Z

Author Name: Tom Elwertowski (Tom Elwertowski)

The last issue is fixed by gcc 4.3 compatibility changes in d049698 (SVN r9293).

status_id was changed from Open to Closed
resolution was changed from to fixed

qgib · 2008-09-10T21:47:09Z

Author Name: Maciej Sieczka - (Maciej Sieczka -)

Buids fine now. I'm on Debian testing amd64, gcc 4.3.1.

qgib · 2009-08-21T22:57:01Z

Author Name: Anónimo (Anónimo)

Milestone Version 1.0.0 deleted

qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS labels May 24, 2019

qgib closed this as completed May 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

crash when creating new GRASS location on Windows #11104

crash when creating new GRASS location on Windows #11104

qgib commented Apr 16, 2008

qgib commented May 20, 2008

qgib commented Jul 16, 2008

qgib commented Jul 17, 2008

qgib commented Sep 9, 2008

qgib commented Sep 9, 2008

qgib commented Sep 10, 2008 •

edited

Loading

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Aug 21, 2009

crash when creating new GRASS location on Windows #11104

crash when creating new GRASS location on Windows #11104

Comments

qgib commented Apr 16, 2008

qgib commented May 20, 2008

qgib commented Jul 16, 2008

qgib commented Jul 17, 2008

qgib commented Sep 9, 2008

qgib commented Sep 9, 2008

qgib commented Sep 10, 2008 • edited Loading

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Sep 10, 2008

qgib commented Aug 21, 2009

qgib commented Sep 10, 2008 •

edited

Loading