Invalid use of stream operator dxf2shp converter

[qgib]

Author Name: Mateusz Loskot - (Mateusz Loskot -)
Original Redmine Issue: 1236

Redmine category:c++_plugins
Assignee: nobody -

---

logfile object below is of std::ostream type:

logfile << "(Add Circle  (%6.3f, %6.3f, %6.3f) %6.3f\
", data.cx, data.cy, data.cz, data.radius;

For ostream, printf-like formating is not defined, colon operator between data variables has no effect, so the statement above outputs this:

(Add Circle  (%6.3f, %6.3f, %6.3f) %6.3f

Generally, the logfile usage above does not make much sense.

BTW, it is really a bad idea to load the whole std namespace in a header file. using namespace std directive should never be used in a header file. See [source:trunk/qgis/src/plugins/dxf2shp_converter/builder.h@9036#L28 builder.h], line 28

[qgib]

Author Name: Mateusz Loskot - (Mateusz Loskot -)

---

I've forgot to tell where the buggy usage of stream occurs: [source:trunk/qgis/src/plugins/dxf2shp_converter/builder.cpp@9036#L398 builder.cpp], line 398

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

I cleaned up the dxf2shp plugin a bit in 07c905b (SVN r9133)

---

• resolution was changed from to fixed
• status_id was changed from Open to Closed