Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addGroup() never allows adding to the "invisible root" group #16008

Closed
qgib opened this issue Dec 14, 2012 · 13 comments
Closed

addGroup() never allows adding to the "invisible root" group #16008

qgib opened this issue Dec 14, 2012 · 13 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Dec 14, 2012

Author Name: Sandro Santilli (@strk)
Original Redmine Issue: 6879
Affected QGIS version: master
Redmine category:map_legend
Assignee: Sandro Santilli


The code for addGroup defaults to the so-called "invisible root item" as the parent,
but then refuses to add there because the "invisible root item" is not a group.

This makes it impossible to add a group to the root, basically (from python)

@qgib
Copy link
Contributor Author

qgib commented Dec 17, 2012

Author Name: Sandro Santilli (@strk)


Fixed in changeset "122cff7859b74b213ba0bdc143850f635d122529".


  • status_id was changed from Open to Closed

@qgib
Copy link
Contributor Author

qgib commented Dec 23, 2012

Author Name: Alexander Bruy (@alexbruy)


After this commit it is impossible to create groups in empty project or add new group without selecting existing item in legend


  • status_id was changed from Closed to Reopened

@qgib
Copy link
Contributor Author

qgib commented Dec 24, 2012

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Normal to Severe/Regression

@qgib
Copy link
Contributor Author

qgib commented Dec 25, 2012

Author Name: Giovanni Manghi (@gioman)


maybe somwhow this commit fixed also #16008

if it is going to be reverted please check again also #16008.

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Sandro Santilli (@strk)


Alex, when I tested this the db_manager plugin (sub-plugin topoviewer) was successfully adding groups to the "invisible root". Are you talking about GUI or python API or what ?

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Giovanni Manghi (@gioman)


Sandro Santilli wrote:

Alex, when I tested this the db_manager plugin (sub-plugin topoviewer) was successfully adding groups to the "invisible root". Are you talking about GUI or python API or what ?

GUI (I can confirm the issue)

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Alexander Bruy (@alexbruy)


Sandro, I tested this from GUI

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Sandro Santilli (@strk)


Confirmed. I'm on it.


  • assigned_to_id was configured as Sandro Santilli

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Sandro Santilli (@strk)


Fixed in changeset "816c32bd064f1d8871f194f40bb701c899c5373d".


  • status_id was changed from Reopened to Closed

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Sandro Santilli (@strk)


there might be another regression, specifically the impossibility to determine where the new group is added (ie: now if you don't select a group item the new group is added to the root, not to the same group of the selected layer).

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Giovanni Manghi (@gioman)


Sandro Santilli wrote:

there might be another regression, specifically the impossibility to determine where the new group is added (ie: now if you don't select a group item the new group is added to the root, not to the same group of the selected layer).

if I understand well, yes is a regression, as before selecting a group and creating a new group allowed to have immediately a nested group.


  • status_id was changed from Closed to Reopened

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Sandro Santilli (@strk)


You didn't understand. What you describe is still possible.
Anyway I fixed what I meant with 7344368

Please reopen if anything else is still missing


  • status_id was changed from Reopened to Closed
  • resolution was changed from to fixed

@qgib
Copy link
Contributor Author

qgib commented Dec 26, 2012

Author Name: Giovanni Manghi (@gioman)


if I understand well

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering labels May 24, 2019
@qgib qgib added this to the Version 2.0.0 milestone May 24, 2019
@qgib qgib closed this as completed May 24, 2019
JamesShaeffer pushed a commit to JamesShaeffer/QGIS that referenced this issue Nov 20, 2019
Now empty sets return NULL values for invalid statistics

(cherry-picked from 64f8b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering
Projects
None yet
Development

No branches or pull requests

1 participant