Merge tool bug when a shapefile is loaded multiple times #16483

qgib · 2013-04-07T17:33:42Z

Author Name: Olivier Dalang (@olivierdalang)
Original Redmine Issue: 7540
Affected QGIS version: master
Redmine category:digitising

Hi !

When a Shapefile is loaded multiple times (either in the same project via "duplicate layer" or in two different QGis instances), there is a critical bug upon merging features.

Both merged parts simply disappear without any error (though it seems sometimes QGis crashes).

To reproduce:

create a new shapefile (line or polygon)
enter edit mode
draw a feature and split it several times with the scissor tool
exit edit mode
duplicate the layer
enter edit mode on one of the two layers
select two line segments and merge them with the merge tool
exit edit mode
reload the project and see!!

Related issue(s): #17515 (relates)
Redmine related issue(s): 8822

qgib · 2013-04-08T12:07:06Z

Author Name: Giovanni Manghi (@gioman)

it is a regression since 1.8? I'm not able to replicate the issue here, but maybe I'm doing it wrong.

status_id was changed from Open to Feedback

qgib · 2013-04-08T13:58:24Z

Author Name: Olivier Dalang (@olivierdalang)

Yes it's a regression, the problem does not show up in 1.8...

Here (Windows 7) it seems to happen every time when following those steps.

If confirmed, this should be a blocker, since it leads to data corruption.

qgib · 2013-04-08T13:59:15Z

Author Name: Giovanni Manghi (@gioman)

priority_id was changed from Normal to Severe/Regression

qgib · 2013-04-22T04:45:13Z

Author Name: Radim Blazek (@blazek)

reload the project and see !!

What does it mean "reload the project"? Reopen project file or refresh display?

qgib · 2013-04-22T05:37:52Z

Author Name: Olivier Dalang (@olivierdalang)

Actually, when you refresh display only :

on the layer that was not edited, you see that the two merged parts have disappeared
on the layer that was edited, you see the two merged parts plus the result of the merge

But actually, I'm just discovering that the shapefile seems in a deeper mess, even after reloading : if you create a new polygon, no matter what shape, it will take the shape of the result of the merge.

Here's a screencast of the procedure :
https://www.dropbox.com/s/84nj515s6mfu09f/mergeBug2.avi?m

qgib · 2013-06-01T23:47:58Z

Author Name: Giovanni Manghi (@gioman)

status_id was changed from Feedback to Open

qgib · 2013-06-27T23:10:28Z

Author Name: Giovanni Manghi (@gioman)

category_id was configured as Digitising

qgib · 2013-07-01T13:53:31Z

Author Name: Salvatore Larosa (@slarosa)

is it still true ?

following the above steps I did not get any crash !
tested with a polygon layer and I do not see unusual behavior.

qgib · 2013-07-02T02:01:25Z

Author Name: Giovanni Manghi (@gioman)

following the above steps I did not get any crash !
tested with a polygon layer and I do not see unusual behavior.

I don't think it causes crash, it causes data corruption.

qgib · 2013-07-08T07:43:05Z

Author Name: Jürgen Fischer (@jef-n)

Giovanni Manghi wrote:

I don't think it causes crash, it causes data corruption.

So you can reproduce the problem? Just checking, if I should try harder...

status_id was changed from Open to Feedback

qgib · 2013-07-08T22:40:23Z

Author Name: Giovanni Manghi (@gioman)

So you can reproduce the problem? Just checking, if I should try harder...

no I can't.

Olivier still true for you?

qgib · 2013-07-08T23:26:07Z

Author Name: Olivier Dalang (@olivierdalang)

Hi !

The behavior changed a little bit but I still get data corruption (with master from yesterday, under Windows 7).
It's no more necessary to reload the project to see the data loss.

Here's a screencast : https://www.dropbox.com/s/g70fkaus6j40vll/mergeBug4.avi

qgib · 2013-07-09T00:51:50Z

Author Name: Jürgen Fischer (@jef-n)

ok, I can reproduce it now. I suspect it's a file locking issue in OGR (might be tied to windows). Looking into GDAL now...

status_id was changed from Feedback to Open

qgib · 2013-07-09T01:30:27Z

Author Name: Jürgen Fischer (@jef-n)

assigned_to_id was configured as Jürgen Fischer

qgib · 2013-07-09T05:25:52Z

Author Name: Jürgen Fischer (@jef-n)

Fixed in changeset "78b04df91a1b85ee70ff5b326980f480b3069d47".

status_id was changed from Open to Closed

qgib · 2013-07-09T05:28:50Z

Author Name: Jürgen Fischer (@jef-n)

Jürgen Fischer wrote:

Fixed in changeset "78b04df91a1b85ee70ff5b326980f480b3069d47".

It was caused by locking. QGIS does a REPACK after deleting and that silently fails with current OGR. "GDAL pull request !#17":OSGeo/gdal#17 should fix this by adding an error message. reopening the original DBF if it can't be removed and cleaning up the @*_packed.dbf@.

Nevertheless QGIS now checks if there still is a @*_packed.dbf@ to detect that the REPACK failed and reopens the dataset in that case.

qgib · 2014-10-04T11:48:08Z

Author Name: Giovanni Manghi (@gioman)

Sorry to reopen this, seems master still affected. See also #19415

status_id was changed from Closed to Reopened
fixed_version_id was changed from Version 2.0.0 to Version 2.6

qgib · 2014-10-21T00:47:34Z

Author Name: Jürgen Fischer (@jef-n)

assigned_to_id removed Jürgen Fischer

qgib · 2014-10-24T07:11:39Z

Author Name: Giovanni Manghi (@gioman)

it is pretty easy to replicate this issue, it is just needed to "insist" a bit. Here two screencast, that as some point show that after removing a shape and re-adding it features are lost!

The second show also a possible bug in the "split features" tool.

https://www.dropbox.com/s/rpjcn8gpn75r31m/t7540_1.mp4?dl=0

https://www.dropbox.com/s/9n9a7j1puugwpnr/t7540_2.mp4?dl=0

qgib · 2014-10-24T07:16:38Z

Author Name: Giovanni Manghi (@gioman)

Giovanni Manghi wrote:

Sorry to reopen this, seems master still affected. See also #19415

after all it does not seems related... I have a VM with qgis running against gdal/ogr trunk and I can still see the issue described in this ticket.

qgib · 2014-10-30T06:13:55Z

Author Name: Giovanni Manghi (@gioman)

it seems this could have been solved by this 4cf08c5

status_id was changed from Reopened to Feedback

qgib · 2014-10-31T04:55:20Z

Author Name: Jürgen Fischer (@jef-n)

fixed_version_id was changed from Version 2.6 to Future Release - High Priority

qgib · 2014-11-03T13:51:06Z

Author Name: Giovanni Manghi (@gioman)

after 4cf08c5 I really cannot make to replicate this issue. That commit solves also partially #19349 (but only for the case of edited features, still there is an issue with deleted ones).

Please reopen if necessary.

status_id was changed from Feedback to Closed
resolution was changed from to fixed/implemented

Should technically be MultiPoint ((-20 -90), (-20 -88)), but it's nice to be forgiving and accept as wide a range of WKT formats as possible Fix qgis#16483 (cherry-picked from ef6c8b)

qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality Crash/Data Corruption labels May 24, 2019

qgib added this to the Future Release - High Priority milestone May 24, 2019

qgib closed this as completed May 24, 2019

This was referenced May 25, 2019

OGR: Repack in running session #17515

Closed

Deleted/edited features within SHAPEFILE are still recognized in other software packages #19349

Closed

qgib mentioned this issue May 25, 2019

Merge tool bug when a shapefile is loaded multiple times #19415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge tool bug when a shapefile is loaded multiple times #16483

Merge tool bug when a shapefile is loaded multiple times #16483

qgib commented Apr 7, 2013 •

edited

Loading

qgib commented Apr 8, 2013

qgib commented Apr 8, 2013

qgib commented Apr 8, 2013

qgib commented Apr 22, 2013

qgib commented Apr 22, 2013

qgib commented Jun 1, 2013

qgib commented Jun 27, 2013

qgib commented Jul 1, 2013

qgib commented Jul 2, 2013

qgib commented Jul 8, 2013

qgib commented Jul 8, 2013

qgib commented Jul 8, 2013

qgib commented Jul 9, 2013

qgib commented Jul 9, 2013

qgib commented Jul 9, 2013

qgib commented Jul 9, 2013

qgib commented Oct 4, 2014 •

edited

Loading

qgib commented Oct 21, 2014

qgib commented Oct 24, 2014

qgib commented Oct 24, 2014 •

edited

Loading

qgib commented Oct 30, 2014

qgib commented Oct 31, 2014

qgib commented Nov 3, 2014 •

edited

Loading

Merge tool bug when a shapefile is loaded multiple times #16483

Merge tool bug when a shapefile is loaded multiple times #16483

Comments

qgib commented Apr 7, 2013 • edited Loading

qgib commented Apr 8, 2013

qgib commented Apr 8, 2013

qgib commented Apr 8, 2013

qgib commented Apr 22, 2013

qgib commented Apr 22, 2013

qgib commented Jun 1, 2013

qgib commented Jun 27, 2013

qgib commented Jul 1, 2013

qgib commented Jul 2, 2013

qgib commented Jul 8, 2013

qgib commented Jul 8, 2013

qgib commented Jul 8, 2013

qgib commented Jul 9, 2013

qgib commented Jul 9, 2013

qgib commented Jul 9, 2013

qgib commented Jul 9, 2013

qgib commented Oct 4, 2014 • edited Loading

qgib commented Oct 21, 2014

qgib commented Oct 24, 2014

qgib commented Oct 24, 2014 • edited Loading

qgib commented Oct 30, 2014

qgib commented Oct 31, 2014

qgib commented Nov 3, 2014 • edited Loading

qgib commented Apr 7, 2013 •

edited

Loading

qgib commented Oct 4, 2014 •

edited

Loading

qgib commented Oct 24, 2014 •

edited

Loading

qgib commented Nov 3, 2014 •

edited

Loading