Relations Subforms - Start/Stop editing problem

[qgib]

Author Name: Pedro Venâncio (Pedro Venâncio)
Original Redmine Issue: 11524
Affected QGIS version: master
Redmine category:forms
Assignee: Matthias Kuhn

---

There is a problem in toggle editing button of subforms.

To start editing, you need to click 2-3 times to toggle editing button. The same happens to stop editing.

This problem is recent in master, but I can not say how long, because I have not used this feature in master in the last days (maybe two weeks).

Tested with QGIS 2.5.0-115 (OSGeo4W 64bits).

---

• bug.tar.bz2 (Benjamin Trigona-Harany)
• qgis_11524.diff (Benjamin Trigona-Harany)

[qgib]

Author Name: Pedro Venâncio (Pedro Venâncio)

---

Sorry, I forgot to fill the Category -> +Forms+.

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

I have seen this on master/linux too.

---

• category_id was configured as Forms

[qgib]

Author Name: Denis Rouzaud (@3nids)

---

I also confirm.
Would be quite painful to release with this one.

---

• assigned_to_id was configured as Matthias Kuhn

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

quick sample project?

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

Fixed in changeset "48af54316f49d10187e92be9343c57e0a06ef72e".

---

• status_id was changed from Open to Closed

[qgib]

Author Name: Denis Rouzaud (@3nids)

---

that did not solve the problem for me.
toggling the editing button does not change anything in the embed form.

---

• status_id was changed from Closed to Reopened

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

Denis Rouzaud wrote:

that did not solve the problem for me.
toggling the editing button does not change anything in the embed form.

seems to work here, just tested qgis 2.6 from osgeo4w.

---

• status_id was changed from Reopened to Feedback

[qgib]

Author Name: Pedro Venâncio (Pedro Venâncio)

---

Giovanni Manghi wrote:

Denis Rouzaud wrote:

that did not solve the problem for me.
toggling the editing button does not change anything in the embed form.

seems to work here, just tested qgis 2.6 from osgeo4w.

Hi Denis,

I've tested it with QGIS 2.6 on Windows and Linux and the problem seems resolved.

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

I assume that this is really fixed as any test (on Windows and Linux) show it is, please reopen if necessary.

---

• status_id was changed from Feedback to Closed
• resolution was changed from to fixed/implemented

[qgib]

Author Name: Larry Shaffer (Larry Shaffer)

---

Hi,

Not entirely fixed yet. If the child layer of the relation is left in edit mode when the dialog is closed, the 3-click issue (just for starting editing of the child) appears again on next opening of the same dialog.

Reopening the issue so another user may submit a suggested patch and sample project.

---

• fixed_version_id was changed from Version 2.6 to Version 2.8
• status_id was changed from Closed to Reopened
• priority_id was changed from Severe/Regression to High
• resolution was changed from fixed/implemented to

[qgib]

Author Name: Benjamin Trigona-Harany (Benjamin Trigona-Harany)

---

Hello,

I did some testing and the issue appears to be that when creating QgsRelationEditorWidget, we need to set the button toggle state only once the relation feature is set with setRelationFeature(). You can see the bug in the attached project in 2.6.1 by editing the parent feature.

The attached patch should fix the issue.

---

• 8280 was configured as qgis_11524.diff
• 8279 was configured as bug.tar.bz2

---

• qgis_11524.diff (Benjamin Trigona-Harany) - patch
• bug.tar.bz2 (Benjamin Trigona-Harany) - QGIS Project and data files

[qgib]

Author Name: Matthias Kuhn (@m-kuhn)

---

Patch applied in ba495f3
Thank you very much Benjamin.
If you have further fixes or improvements, it would be best to create pull requests for it on github, that way they can be easier reviewed, discussed and merged.

---

• status_id was changed from Reopened to Closed