Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom hightlight color for 'Identify Features' tool not applied when right clicking on the map canvas #20201

Closed
qgib opened this issue Jan 16, 2015 · 3 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering

Comments

@qgib
Copy link
Contributor

qgib commented Jan 16, 2015

Author Name: Koen De Munter (Koen De Munter)
Original Redmine Issue: 11996
Affected QGIS version: master
Redmine category:map_canvas


When you change the color of the Identify Features tool, that color is applied to the objects you clicked on the map.
This change of color is not consistent in the following situation:

If you click on the map, and features of multiple visible layers have been hit, a grey box appears giving the option to choose of which layer you'd like to consult the appointed features. But, when you hover over the options, the default red color is used for indicating the respective features. As you eventually choose of the options, your customized color returns.

Bottom-line: the custom defined color is not used for dynamic indication of the features on the map when hovering over the options if features from different layers have been activated.

@qgib
Copy link
Contributor Author

qgib commented Jan 18, 2015

Author Name: Giovanni Manghi (@gioman)


It is not related to the "mode" (current layer, top down, layer selection, etc.). The custom color is never used when right clicking on the map canvas to choose what layer the identify should be applied.


  • os_version was changed from Windows 7 Pro (SP1) to
  • fixed_version_id was changed from Future Release - Nice to have to Future Release - Lower Priority
  • subject was changed from Custom color 'Identify Features' tool not applied to options 'Layer selection' mode to Custom hightlight color for 'Identify Features' tool not applied when right clicking on the map canvas
  • version was changed from 2.6.1 to master
  • operating_system was changed from Windows to

@qgib
Copy link
Contributor Author

qgib commented Jan 18, 2015

Author Name: Richard Duivenvoorde (@rduivenvoorde)


the color is set here
https://github.com/qgis/QGIS/blob/master/src/gui/qgsidentifymenu.cpp#L583
it is 255,0,0 now (red)

I've added a pull request to use the same colors as the user defined colors:

#1839

NOTE: IF the user did NOT set an opacity <1 here for the color you will have a fully opaque 'rubberband', so will not 'see through' the different features in different layers. BUT that's up to the user to do it right.
Using the default color (red 50% opaque) it is ok.

@qgib
Copy link
Contributor Author

qgib commented Jan 21, 2015

Author Name: Richard Duivenvoorde (@rduivenvoorde)


Code is merged in master, plz test and reopen if you see other problems.


  • status_id was changed from Open to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering labels May 25, 2019
@qgib qgib added this to the Future Release - Lower Priority milestone May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering
Projects
None yet
Development

No branches or pull requests

1 participant