Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Label/diagram placement on centroid is broken for multipolygons #21600

Closed
qgib opened this issue Oct 10, 2015 · 7 comments
Closed
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Labeling Related to QGIS map labeling
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Oct 10, 2015

Author Name: Anita Graser (@anitagraser)
Original Redmine Issue: 13558
Affected QGIS version: master
Redmine category:labelling


Label/diagram placement on centroid in master seems to be off compared to 2.10: for multipolygons, it seems to randomly chose the centroid of one part rather than the old behavior which seemed to use the whole multipart feature to compute the centroid.

In the following example the diagram is put on the centroid with high priority and the label settings are shown.

!210-vs-master.png!

Tested on nightly OSGeo4W


@qgib
Copy link
Contributor Author

qgib commented Oct 10, 2015

Author Name: Anita Graser (@anitagraser)


  • 9163 was configured as 210-vs-master.png

@qgib
Copy link
Contributor Author

qgib commented Oct 10, 2015

Author Name: Nyall Dawson (@nyalldawson)


  • priority_id was changed from High to Severe/Regression

@qgib
Copy link
Contributor Author

qgib commented Oct 10, 2015

Author Name: Anita Graser (@anitagraser)


  • subject was changed from [Regression] Label/diagram placement on centroid is broken for multipolgons to [Regression] Label/diagram placement on centroid is broken for multipolygons

@qgib
Copy link
Contributor Author

qgib commented Oct 10, 2015

Author Name: Anita Graser (@anitagraser)


Update info: If label all parts of multipart feature is enabled ...

When the complete multipolygon is visible in the map view, there are no label candidates on the main land. They appear if the feature is moved partially outside the map view:

!label-partial-feature.png!


  • 9164 was configured as label-partial-feature.png

@qgib
Copy link
Contributor Author

qgib commented Oct 10, 2015

Author Name: Nyall Dawson (@nyalldawson)


Seems to be caused by the recent GEOS c++ changes (tolerance) - if I build without the geos c++ library set then the placement matches 2.10. Can also confirm that #2353 fixes this.

@qgib
Copy link
Contributor Author

qgib commented Oct 12, 2015

Author Name: Nyall Dawson (@nyalldawson)


Can you please re-test with current master? PR 2353 has been merged, which fixed the issue for me.


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Oct 13, 2015

Author Name: Anita Graser (@anitagraser)


Looks fine today. Thanks!


  • resolution was changed from to fixed/implemented
  • status_id was changed from Feedback to Closed
  • fixed_version_id was changed from Future Release - High Priority to Version 2.12
  • done_ratio was changed from 0 to 100

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Labeling Related to QGIS map labeling labels May 25, 2019
@qgib qgib added this to the Version 2.12 milestone May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Labeling Related to QGIS map labeling
Projects
None yet
Development

No branches or pull requests

1 participant