Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling Layer Properties Dialog does not cancel changes made in "Provider feature filter" section #21658

Closed
qgib opened this issue Oct 16, 2015 · 2 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@qgib
Copy link
Contributor

qgib commented Oct 16, 2015

Author Name: Harrissou Santanna (@DelazJ)
Original Redmine Issue: 13620
Affected QGIS version: master


Open a layer Properties > General tab
write a formule in the Query builder and click "Test"
The query instead of just being tested, is also applied in the map canvas. I'm not sure if this behaviour is good but why not, since it shows how layer will be.
Now Click "OK" in the query builder dialog and click "CANCEL" in the Properties Dialog : your layer will be kept queried, despite you cancelled the process.

Shouldn't all the not yet applied changes, made within the Layer Properties dialog, be reversed when user hits Cancel button?

Occured since QGIS 2.4 at least

@qgib
Copy link
Contributor Author

qgib commented Nov 17, 2015

Author Name: Sebastian Dietrich (Sebastian Dietrich)


Please see "PR 2480":#2480 for a fix.

@qgib
Copy link
Contributor Author

qgib commented Nov 18, 2015

Author Name: Anónimo (Anónimo)


Fixed in changeset "5399855566c504953151c4b56b6ae1e0d5097a5a".


  • status_id was changed from Open to Closed

@qgib qgib added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

No branches or pull requests

1 participant