Joins are duplicated when duplicating layers

[qgib]

Author Name: Frank Sokolic (Frank Sokolic)
Original Redmine Issue: 14298
Affected QGIS version: master
Redmine category:gui
Assignee: Sebastian Dietrich

---

When a layer is duplicated any joins defined for that layer are also duplicated. This can be replicated as follows:

1. Create a Join via Layer Properties > Joins
2. Right-click on the Layer in the Table of Contents and select Duplicate from the context-sensitive menu
3. Open Layer Properties > Joins for the duplicated layer and the join appears twice

[qgib]

Author Name: Sebastian Dietrich (Sebastian Dietrich)

---

Confirmed on current master (1e80a98) on Windows.

---

• os_version was changed from 15.10 64 bit to
• operating_system was changed from Ubuntu to

[qgib]

Author Name: Sebastian Dietrich (Sebastian Dietrich)

---

Duplicating vector joins was introduced by

• 9ed1803 (joins are not created when duplicating a layer #17054)
• and again by 57b5eb9 (virtual fields not re-created when duplicating a layer #22193, which was not about joins at all)

See "PR 2816":#2816 for a solution.

---

• done_ratio was changed from 0 to 100
• pull_request_patch_supplied was changed from 0 to 1
• assigned_to_id was configured as Sebastian Dietrich
• status_id was changed from Open to In Progress

[qgib]

Author Name: Sebastian Dietrich (Sebastian Dietrich)

---

Flagging this as Blocker because it is a regression from 2.12

---

• fixed_version_id was configured as Version 2.14
• priority_id was changed from Normal to Severe/Regression

[qgib]

Author Name: Anónimo (Anónimo)

---

Fixed in changeset "0c0d72bb0356f078807eefcc02f81e2e4e6585bf".

---

• status_id was changed from In Progress to Closed