Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual layer: QGIS crashes when testing a wrong expression #24382

Closed
qgib opened this issue Apr 27, 2017 · 9 comments
Closed

Virtual layer: QGIS crashes when testing a wrong expression #24382

qgib opened this issue Apr 27, 2017 · 9 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Regression Something which used to work, but doesn't anymore Vectors Related to general vector layer handling (not specific data formats)
Milestone
Version 3.0

Comments

@qgib
Copy link
Contributor

qgib commented Apr 27, 2017

Author Name: Harrissou Santanna (@DelazJ)
Original Redmine Issue: 16473
Affected QGIS version: master
Redmine category:vectors
Assignee: Sandro Santilli

(trying the new report system)

User Feedback

I open the Add virtual layer dialog and click on the Test button (I know, it's weird to not have written an expression). And Boum! QGIS crashes.
I think it should not. Doing the same thing in 2.18 returns a "Malformed URL" message which is a better way to handle such error.

Report Details

Crash ID: ac24918ac24cafc2fa6aa21fbcfe0e515c099996

Stack Trace

((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
(Qt5Core) QMetaObject::activate (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::clicked (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::click (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::mouseReleaseEvent (unknown file):(unknown line)
(Qt5Widgets) QWidget::event (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::sendMouseEvent (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
((unknown module)) QGuiApplicationPrivate::processMouseEvent (unknown file):(unknown line)
((unknown module)) QWindowSystemInterface::sendWindowSystemEvents (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) CallWindowProcW (unknown file):(unknown line)
((unknown module)) DispatchMessageW (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) qt_plugin_query_metadata (unknown file):(unknown line)
(Qt5Core) QEventLoop::exec (unknown file):(unknown line)
(Qt5Widgets) QDialog::exec (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
(Qt5Core) QMetaObject::activate (unknown file):(unknown line)
(Qt5Widgets) QAction::activate (unknown file):(unknown line)
(Qt5Widgets) QMenu::actionGeometry (unknown file):(unknown line)
(Qt5Widgets) QMenu::actionGeometry (unknown file):(unknown line)
(Qt5Widgets) QMenu::mouseReleaseEvent (unknown file):(unknown line)
(Qt5Widgets) QWidget::event (unknown file):(unknown line)
(Qt5Widgets) QMenu::event (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::sendMouseEvent (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
((unknown module)) QGuiApplicationPrivate::processMouseEvent (unknown file):(unknown line)
((unknown module)) QWindowSystemInterface::sendWindowSystemEvents (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) CallWindowProcW (unknown file):(unknown line)
((unknown module)) DispatchMessageW (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) qt_plugin_query_metadata (unknown file):(unknown line)
(Qt5Core) QEventLoop::exec (unknown file):(unknown line)
(Qt5Core) QCoreApplication::exec (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) BaseThreadInitThunk (unknown file):(unknown line)
((unknown module)) RtlUserThreadStart (unknown file):(unknown line)

Plugins

Project Info

QGIS Info

QGIS Version: 2.99.0-Master
QGIS code revision: f1d4ac3
Compiled against Qt: 5.7.1
Running against Qt: 5.7.1
Compiled against GDAL: 2.1.3
Running against GDAL: 2.1.3

System Info

CPU Type: x86_64
Kernel Type: winnt
Kernel Version: 10.0.14393
@qgib
Copy link
Contributor Author

qgib commented Apr 28, 2017

Author Name: Giovanni Manghi (@gioman)

  • category_id was configured as Vectors

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Nathan Woodrow (@NathanW2)

Seems I also need to fix up the symbols laoding path for osgeo4w so that we get symbols on the crash correctly loaded.

  • description was changed from (trying the new report system)

User Feedback

I open the Add virtual layer dialog and click on the Test button (I know, it's weird to not have written an expression). And Boum! QGIS crashes.
I think it should not. Doing the same thing in 2.18 returns a "Malformed URL" message which is a better way to handle such error.

Report Details

Crash ID: ac24918ac24cafc2fa6aa21fbcfe0e515c099996

Stack Trace

((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
(Qt5Core) QMetaObject::activate (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::clicked (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::click (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::mouseReleaseEvent (unknown file):(unknown line)
(Qt5Widgets) QWidget::event (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::sendMouseEvent (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
((unknown module)) QGuiApplicationPrivate::processMouseEvent (unknown file):(unknown line)
((unknown module)) QWindowSystemInterface::sendWindowSystemEvents (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) CallWindowProcW (unknown file):(unknown line)
((unknown module)) DispatchMessageW (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) qt_plugin_query_metadata (unknown file):(unknown line)
(Qt5Core) QEventLoop::exec (unknown file):(unknown line)
(Qt5Widgets) QDialog::exec (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
(Qt5Core) QMetaObject::activate (unknown file):(unknown line)
(Qt5Widgets) QAction::activate (unknown file):(unknown line)
(Qt5Widgets) QMenu::actionGeometry (unknown file):(unknown line)
(Qt5Widgets) QMenu::actionGeometry (unknown file):(unknown line)
(Qt5Widgets) QMenu::mouseReleaseEvent (unknown file):(unknown line)
(Qt5Widgets) QWidget::event (unknown file):(unknown line)
(Qt5Widgets) QMenu::event (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::sendMouseEvent (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
((unknown module)) QGuiApplicationPrivate::processMouseEvent (unknown file):(unknown line)
((unknown module)) QWindowSystemInterface::sendWindowSystemEvents (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) CallWindowProcW (unknown file):(unknown line)
((unknown module)) DispatchMessageW (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) qt_plugin_query_metadata (unknown file):(unknown line)
(Qt5Core) QEventLoop::exec (unknown file):(unknown line)
(Qt5Core) QCoreApplication::exec (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) BaseThreadInitThunk (unknown file):(unknown line)
((unknown module)) RtlUserThreadStart (unknown file):(unknown line)

Plugins

Project Info

QGIS Info

QGIS Version: 2.99.0-Master
QGIS code revision: f1d4ac3
Compiled against Qt: 5.7.1
Running against Qt: 5.7.1
Compiled against GDAL: 2.1.3
Running against GDAL: 2.1.3

System Info

CPU Type: x86_64
Kernel Type: winnt
Kernel Version: 10.0.14393 to (trying the new report system)

User Feedback

I open the Add virtual layer dialog and click on the Test button (I know, it's weird to not have written an expression). And Boum! QGIS crashes.
I think it should not. Doing the same thing in 2.18 returns a "Malformed URL" message which is a better way to handle such error.

Report Details

Crash ID: ac24918ac24cafc2fa6aa21fbcfe0e515c099996

Stack Trace

((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
((unknown module)) isProvider (unknown file):(unknown line)
(Qt5Core) QMetaObject::activate (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::clicked (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::click (unknown file):(unknown line)
(Qt5Widgets) QAbstractButton::mouseReleaseEvent (unknown file):(unknown line)
(Qt5Widgets) QWidget::event (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::sendMouseEvent (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
((unknown module)) QGuiApplicationPrivate::processMouseEvent (unknown file):(unknown line)
((unknown module)) QWindowSystemInterface::sendWindowSystemEvents (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) CallWindowProcW (unknown file):(unknown line)
((unknown module)) DispatchMessageW (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) qt_plugin_query_metadata (unknown file):(unknown line)
(Qt5Core) QEventLoop::exec (unknown file):(unknown line)
(Qt5Widgets) QDialog::exec (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
(Qt5Core) QMetaObject::activate (unknown file):(unknown line)
(Qt5Widgets) QAction::activate (unknown file):(unknown line)
(Qt5Widgets) QMenu::actionGeometry (unknown file):(unknown line)
(Qt5Widgets) QMenu::actionGeometry (unknown file):(unknown line)
(Qt5Widgets) QMenu::mouseReleaseEvent (unknown file):(unknown line)
(Qt5Widgets) QWidget::event (unknown file):(unknown line)
(Qt5Widgets) QMenu::event (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::sendMouseEvent (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QSizePolicy::QSizePolicy (unknown file):(unknown line)
(Qt5Widgets) QApplicationPrivate::notify_helper (unknown file):(unknown line)
(Qt5Widgets) QApplication::notify (unknown file):(unknown line)
((unknown module)) QgsSvgCache::statusChanged (unknown file):(unknown line)
(Qt5Core) QCoreApplication::notifyInternal2 (unknown file):(unknown line)
((unknown module)) QGuiApplicationPrivate::processMouseEvent (unknown file):(unknown line)
((unknown module)) QWindowSystemInterface::sendWindowSystemEvents (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) CallWindowProcW (unknown file):(unknown line)
((unknown module)) DispatchMessageW (unknown file):(unknown line)
(Qt5Core) QEventDispatcherWin32::processEvents (unknown file):(unknown line)
((unknown module)) qt_plugin_query_metadata (unknown file):(unknown line)
(Qt5Core) QEventLoop::exec (unknown file):(unknown line)
(Qt5Core) QCoreApplication::exec (unknown file):(unknown line)
((unknown module)) QgisApp::newMapCanvas (unknown file):(unknown line)
((unknown module)) BaseThreadInitThunk (unknown file):(unknown line)
((unknown module)) RtlUserThreadStart (unknown file):(unknown line)

Plugins

Project Info

QGIS Info

QGIS Version: 2.99.0-Master
QGIS code revision: f1d4ac3
Compiled against Qt: 5.7.1
Running against Qt: 5.7.1
Compiled against GDAL: 2.1.3
Running against GDAL: 2.1.3

System Info

CPU Type: x86_64
Kernel Type: winnt
Kernel Version: 10.0.14393

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)

  • regression was configured as 1

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)

  • priority_id was changed from Severe/Regression to High

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)

  • easy_fix was configured as 0

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Sandro Santilli (@strk)

I cannot reproduce with 0f1f14a174 (pre-3.0.0).
Hitting the "Test" button with an empty query text does nothing.
Hitting it with some spaces results in an popup complaining about syntax error.

  • status_id was changed from Open to Feedback
  • resolution was changed from to worksforme

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Sandro Santilli (@strk)

  • assigned_to_id was configured as Sandro Santilli

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017 •
edited

Author Name: Harrissou Santanna (@DelazJ)

I think this has been duplicated by #25386 (both reported by me, Sorry :( ) fixed by alessandro.
So closing.
Thanks for giving it a look, Sandro.

  • status_id was changed from Feedback to Closed

@qgib qgib closed this as completed Dec 5, 2017
@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Giovanni Manghi (@gioman)

  • resolution was changed from worksforme to duplicate

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Vectors Related to general vector layer handling (not specific data formats) Regression Something which used to work, but doesn't anymore labels May 25, 2019
@qgib qgib added this to the Version 3.0 milestone May 25, 2019
@qgib qgib mentioned this issue May 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Regression Something which used to work, but doesn't anymore Vectors Related to general vector layer handling (not specific data formats)
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
1 participant
@qgib