Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non valid VRT logic due to GDAL changes in QgsGdalDataItems #24705

Closed
qgib opened this issue Jul 7, 2017 · 2 comments
Closed

Non valid VRT logic due to GDAL changes in QgsGdalDataItems #24705

qgib opened this issue Jul 7, 2017 · 2 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers

Comments

@qgib
Copy link
Contributor

qgib commented Jul 7, 2017

Author Name: Richard Duivenvoorde (@rduivenvoorde)
Original Redmine Issue: 16806
Affected QGIS version: 2.18.0
Redmine category:data_provider
Assignee: Even Rouault


See this thread:
https://lists.osgeo.org/pipermail/qgis-developer/2017-July/049234.html

According to Even the logic here:
https://github.com/qgis/QGIS/blob/master/src/providers/gdal/qgsgdaldataitems.cpp#L246
isn't working anymore for GDAL2:

Quote: " Actually L246 shows a particular case for VRT. But I think this logic is now invalid since GDAL 2.0, since
GDALIdentifyDriver() will now retun "VRT" for a raster VRT, and "OGR_VRT" for a vector VRT (in GDAL 1.X era GDALIdentifyDriver() only worked on raster drivers)"

So probably this code should be updated.

@qgib
Copy link
Contributor Author

qgib commented Oct 20, 2017

Author Name: Even Rouault (@rouault)


Applied in changeset 4907180.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Oct 20, 2017
@qgib
Copy link
Contributor Author

qgib commented Oct 20, 2017

Author Name: Even Rouault (@rouault)


  • resolution was changed from to fixed/implemented
  • version was changed from master to 2.18.0
  • assigned_to_id was configured as Even Rouault

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers
Projects
None yet
Development

No branches or pull requests

1 participant