regression: identify tool's highlight (red point/line/polygon) mislocated when panning/zooming around

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)
Original Redmine Issue: 16824
Affected QGIS version: master
Redmine category:map_tools

---

The attached screencast is self-explanatory.

Steps to reproduce

1. Create a new project
2. Add a polygon layer to your project
3. Select the identify tool, and click on a polygon
4. Pan the map around a bit (using the mouse wheel), you'll notice the selected feature's highlight polygon (red) doesn't get drawn at the right location

---

• identify-highlight-broken.mp4 (Mathieu Pellerin - nIRV)

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

• 11151 was configured as identify-highlight-broken.mp4

---

• identify-highlight-broken.mp4 (Mathieu Pellerin - nIRV)

[qgib]

Author Name: Andreas Neumann (@andreasneumann)

---

Confirmed. Same happens on my QGIS master build 502efd1

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

The regression was caused by this 4659691

Reverting it fixes the wrongly positioned highlight.

[qgib]

Author Name: Radim Blazek (@blazek)

---

The fix resolved this problem:

1. highlight a feature programmatically when it is outside current map canvas extent
2. zoom to that feature
3. the highlight disappears

Please don't simply revert without fixing the original problem.
More info http://lists.osgeo.org/pipermail/qgis-developer/2017-June/048948.html

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Radim, no worries, I didn't commit a revert, I actually reached out to you via github to point out the regression. Happy to test out any commit from you that'd fix the regression.

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Applied in changeset 51170ae.

---

• done_ratio was changed from 0 to 100
• status_id was changed from Open to Closed