Geometry checker crashes when checking a specific vector layer (attached)

[qgib]

Author Name: Antonio Viscomi (@Antoviscomi)
Original Redmine Issue: 16898
Affected QGIS version: 2.18.11
Redmine category:c++_plugins/geometry_checker
Assignee: Sandro Mani

---

hello,
I tried to Use Geometry Checker in a polygon shapefile,

I must check for: -duplicates;
-small overlaps (smaller than 100 sqr. m);
-small gaps (smaller than 1000 sqr. m).

I set create a new layer (with name an path)
then QGIS crashes or freezes.
I try to re-run QGIS,
I reset all option cited above and QGIS crashes yet.
So I think there is a bug that causes crash.
I attach a screenshot and the file I tried to validate
best regards

Antonio

---

• Crash.png (Antonio Viscomi)
• Geologica.zip (Antonio Viscomi)
• bug_record.txt (Antonio Viscomi)
• Bug screenshot.png (Antonio Viscomi)

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

Instant crash also on Linux.

---

• subject was changed from Geometry checker to Geometry checker crashes when checking a specific vector layer (attached)
• category_id was changed from Geometry to C++ plugins/Geometry Checker
• assigned_to_id was configured as Sandro Mani
• regression was changed from 0 to 1

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

No crash on 2.14.16 but also not sure it works as expected, in fact the "fixed" layer is added to the canvas but the result tab is not opened and stay disabled.

[qgib]

Author Name: Antonio Viscomi (@Antoviscomi)

---

Sorry,
I forget to select OS,
I use windows 7 Ultimate x64
Regards

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• version was changed from 2.18.10 to 2.18.11

[qgib]

Author Name: Antonio Viscomi (@Antoviscomi)

---

Also on QGIS 2.99 a48c146 Geometry Checker has a bug:
-I try to check geometry of the same shapefile with the same settings quoted above;
-the check come out fine;
-then I tried to automatically fix errors;
-the progress bar reaches 100%;
-QGIS crashes both in 'Modify input layer' and 'Create a new layer' mode
Best Regards

[qgib]

Author Name: Antonio Viscomi (@Antoviscomi)

---

Today I've updated QGIS MASTER to build 3c58599,
I tried to check geometry of the same file attached above, with the same settings then,
after checking, I flagged Geometry and the plugin crashed instantly and comes out with the attacched report

---

• 11306 was configured as Bug screenshot.png
• 11304 was configured as bug_record.txt

---

• Bug screenshot.png (Antonio Viscomi)
• bug_record.txt (Antonio Viscomi)

[qgib]

Author Name: Sandro Mani (Sandro Mani)

---

The geometry checker is pretty broken in master, I'm working to fix it and improve it with multi-layer support, but the work is not yet ready to be merged.

[qgib]

Author Name: Antonio Viscomi (@Antoviscomi)

---

Sandro Mani wrote:

The geometry checker is pretty broken in master, I'm working to fix it and improve it with multi-layer support, but the work is not yet ready to be merged.

Ok,
many thanks for this information

Good job then

[qgib]

Author Name: Sandro Mani (Sandro Mani)

---

I've finally got to submitting the PR for the new enhanced geometry checker (#5410) for QGIS 3.0+. Testing feedback is very welcome.

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

Please test again after the patch has been merged in master.

---

• status_id was changed from Open to Feedback

[qgib]

Author Name: Antonio Viscomi (@Antoviscomi)

---

Giovanni Manghi wrote:

Please test again after the patch has been merged in master.

Hi everybody,
when this patch will be available in the master?
I've today update it to df0d717 and the patch is not available
greetings

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

Antonio Viscomi wrote:

Giovanni Manghi wrote:

Please test again after the patch has been merged in master.

Hi everybody,
when this patch will be available in the master?
I've today update it to df0d717 and the patch is not available
greetings

after you will see "merged" here #5410

[qgib]

Author Name: Antonio Viscomi (@Antoviscomi)

---

Giovanni Manghi wrote:

Antonio Viscomi wrote:

Giovanni Manghi wrote:

Please test again after the patch has been merged in master.

Hi everybody,
when this patch will be available in the master?
I've today update it to df0d717 and the patch is not available
greetings

ok thanks

after you will see "merged" here #5410

[qgib]

Author Name: Sandro Mani (Sandro Mani)

---

The PR is now merged to master.

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

The patch is against master. Will the fix be backported?

[qgib]

Author Name: Sandro Mani (Sandro Mani)

---

The PR is much more than a fix, it's a major rework of the plugin, and as such no, it won't be backported.

[qgib]

Author Name: Antonio Viscomi (@Antoviscomi)

---

Sandro Mani wrote:

The PR is now merged to master.

I did a quick test on the plugin in the master
and it work perfectly for the file I attached to the beginning of the topic.
many thanks for the excellent work Sandro Mani

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• status_id was changed from Feedback to Closed
• resolution was changed from to fixed/implemented