-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE][Geometry checker] Support checking multiple layers at once, add new checks #5410
Conversation
Also speed up avoid intersections by removing unnecessary geometry cloning
…checks in map CRS
…kErrors, overall code cleanup
… in the setup tab
…led depending on type of layers to be checked
…ctionCheck::fixError
… if layerId is empty
…Pool spatial index
…wo geometries, and ensure that the output is a single-part geometry
…yCheck::replaceFeatureGeometryPart
…res without valid geometry
…log::addError for better performance
…which are to be processed
There's a lot of code here to go through, so I haven't looked this over in depth, but I'm really happy to see the move to the analysis lib (hopefully in future we can use the checker from processing!) and the new unit tests. Quick question: can you confirm that the added code to analysis has no gui dependencies? (Ie no qt widgets or qgis gui classes) |
@nyalldawson Just spotted two unused includes which were indeed QtGui includes.. Should be good now. |
* | ||
* \since QGIS 3.0 | ||
*/ | ||
class GUI_EXPORT QgsVScrollArea : public QScrollArea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manisandro I think this should inherit from QgsScrollArea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, done in bb21395, thanks.
Description
This is a fairly big update to the geometry checker, which besides restoring it's functionality (currently it's completely broken):
There might still be some rough edges here and there, so testing feedback is very welcome. Overall it should however already be pretty stable.