Unable to edit filtered Shapefile Layer after reloading project

[qgib]

Author Name: Christian Roettger (Christian Roettger)
Original Redmine Issue: 17795
Affected QGIS version: master
Redmine category:data_provider/ogr
Assignee: Alessandro Pasotti

---

This seems to be a new bug in 2.18.15 an not really related to #25404
You can't edit a shapefile anymore while a filter is active (CASE 1.). This was possible in .14 :( (its not possible with the linked buhtest.gpkg, too)
I tested this on an older qgis version (2.18.1) where editing the same filtered shape file is possible.

USE CASE:

1. filter shape file
2. save as project
3. reopen => no editing possible
4. remove filter, still no editing possible
5. reopen project => editing possible

Tested on Windows with 2.18.14 and 2.18.15 where it is even worse. In .15 you can't edit a shapefile anymore while a filter is active (CASE 1.). This was possible in .14 :(

More detailed System overview:
QGIS version 2.18.15
QGIS code revision ac2d111
Compiled against Qt 4.8.5
Running against Qt 4.8.5
Compiled against GDAL/OGR 2.2.3
Running against GDAL/OGR 2.2.3
Compiled against GEOS 3.5.0-CAPI-1.9.0
Running against GEOS 3.5.0-CAPI-1.9.0 r4084
PostgreSQL Client Version 9.2.4
SpatiaLite Version 4.3.0
QWT Version 5.2.3
PROJ.4 Version 493
QScintilla2 Version 2.7.2

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Also affects master

---

• version was changed from 2.18.15 to master

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Failing test: elpaso@dd60fcd

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

• category_id was changed from Data Provider to Data Provider/OGR

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

• status_id was changed from Open to In Progress

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

#6000

---

• pull_request_patch_supplied was changed from 0 to 1

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Just to be clear: editing on a filtered layer won't be possible because of the way OGR provider construct a filtered layer, but the bug that prevent to edit a layer when the filter is removed/cleared has been addressed in the PR 6000

[qgib]

Author Name: Anónimo (Anónimo)

---

Applied in changeset 9c85334.

---

• status_id was changed from In Progress to Closed
• done_ratio was changed from 0 to 100

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Backporting now to 2.18

---

• resolution was changed from to fixed/implemented