Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing of a filtered OGR vector layer #26317

Closed
qgib opened this issue Mar 13, 2018 · 8 comments
Closed

Editing of a filtered OGR vector layer #26317

qgib opened this issue Mar 13, 2018 · 8 comments
Labels
Data Provider Related to specific vector, raster or mesh data providers Feature Request

Comments

@qgib
Copy link
Contributor

qgib commented Mar 13, 2018

Author Name: Arjan Mossel (Arjan Mossel)
Original Redmine Issue: 18428

Redmine category:data_provider/ogr


I understand that it will not be possible to allow simultaneous filtering (provider feature filter) and editing of an OGR layer like Shapefile, GeoPackage, plain SQLite ("editing on a filtered layer won't be possible because of the way OGR provider construct a filtered layer", #25691-6). But with SpatiaLite (and other databases?) it should presumably be possible, and in QGIS2 it is (example: https://gis.stackexchange.com/a/231046).

But in QGIS 3.0 the edit option is unavailable when a filter is applied on a SpatiaLite layer. A regression?


Related issue(s): #23942 (relates), #27773 (duplicates)
Redmine related issue(s): 16027, 19951


@qgib
Copy link
Contributor Author

qgib commented Mar 13, 2018

Author Name: Arjan Mossel (Arjan Mossel)


Update: user error. I'd added the SpatiaLite layer via the Vector menu, and therefore it wasn't recognized as SpatiaLite. When added as SpatiaLite it works as desired.

It would be user-friendly to check SQLite data sources for SpatiaLite functionality and offer to use it when it is available.

@qgib
Copy link
Contributor Author

qgib commented Mar 26, 2018

Author Name: Jürgen Fischer (@jef-n)


  • description was changed from I understand that it will not be possible to allow simultaneous filtering (provider feature filter) and editing of an OGR layer like Shapefile, GeoPackage, plain SQLite ("editing on a filtered layer won't be possible because of the way OGR provider construct a filtered layer", https://issues.qgis.org/issues/17795#note-6). But with SpatiaLite (and other databases?) it should presumably be possible, and in QGIS2 it is (example: https://gis.stackexchange.com/a/231046).

But in QGIS 3.0 the edit option is unavailable when a filter is applied on a SpatiaLite layer. A regression? to I understand that it will not be possible to allow simultaneous filtering (provider feature filter) and editing of an OGR layer like Shapefile, GeoPackage, plain SQLite ("editing on a filtered layer won't be possible because of the way OGR provider construct a filtered layer", #25691 (comment)). But with SpatiaLite (and other databases?) it should presumably be possible, and in QGIS2 it is (example: https://gis.stackexchange.com/a/231046).

But in QGIS 3.0 the edit option is unavailable when a filter is applied on a SpatiaLite layer. A regression?

@qgib
Copy link
Contributor Author

qgib commented Sep 16, 2018

Author Name: Alessandro Pasotti (@elpaso)


Due to the way different providers are implemented in QGIS, this is not going to happen unless we proceed with a deep refactoring of the code.

Feel free to open a feature request, but I doubt it will be implemented.


  • status_id was changed from Open to Closed
  • resolution was changed from to wontfix
  • tracker_id was changed from 1 to 2

@qgib
Copy link
Contributor Author

qgib commented Sep 17, 2018

Author Name: Giovanni Manghi (@gioman)


Feel free to open a feature request, but I doubt it will be implemented.

let's keep it open as feature request then, even if is a long shot.


  • category_id was changed from Data Provider/SpatiaLite to Data Provider/OGR
  • resolution was changed from wontfix to
  • status_id was changed from Closed to Open

@qgib
Copy link
Contributor Author

qgib commented Sep 26, 2018

Author Name: Regis Haubourg (@haubourg)


  • subject was changed from Editing of a filtered SpatiaLite layer to Editing of a filtered OGR vector layer

@qgib
Copy link
Contributor Author

qgib commented Sep 27, 2018

Author Name: Alessandro Pasotti (@elpaso)


@qgib
Copy link
Contributor Author

qgib commented Sep 27, 2018

Author Name: Arjan Mossel (Arjan Mossel)


It's getting a bit confusing what the feature request is about now.

  1. My initial question was about editing filtered SpatiaLite, which actually works already.
  2. Then I wondered whether SpatiaLite could be recognized when opening the database via the (wrong) vector menu (i.e. propose to open as SpatiaLite instead of plain SQLite).
  3. But now the title is changed to "Editing of a filtered OGR vector layer", which as I understood from Alessandro Pasotti's comment https://issues.qgis.org/issues/17795#note-6 is not possible.

Are we leaving this open as feature request for 2 or 3?

@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: Jürgen Fischer (@jef-n)


@nyalldawson
Copy link
Collaborator

This is fixed in QGIS 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Provider Related to specific vector, raster or mesh data providers Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants