Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify map tool - don't use douglas-peucker simplification #25979

Closed
qgib opened this issue Feb 13, 2018 · 2 comments
Closed

Simplify map tool - don't use douglas-peucker simplification #25979

qgib opened this issue Feb 13, 2018 · 2 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map Tools Related to non-digitizing map tools

Comments

@qgib
Copy link
Contributor

qgib commented Feb 13, 2018

Author Name: Nyall Dawson (@nyalldawson)
Original Redmine Issue: 18083
Affected QGIS version: master
Redmine category:map_tools
Assignee: Denis Rouzaud


The simplify map tool currently forces Douglas-Peucker simplification (via the QgsGeometry::simplify method). Unfortunately this simplification technique is not ideal as it preserves jagged spikes within line work, making it unusable for cartographic simplification.

A better choice would be to utilise Visvalingam simplification (which is available from the QgsMapToPixelGeometrySimplifier class) - this simplification technique prefers to eliminate narrow jagged spikes, resulting in much more pleasing cartographic simplification.

(Or better - expose this choice to users so that they can select an appropriate simplification technique for their requirements)

@qgib
Copy link
Contributor Author

qgib commented Feb 26, 2018

Author Name: Nyall Dawson (@nyalldawson)


Applied in changeset dce2188.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Feb 26, 2018
@qgib
Copy link
Contributor Author

qgib commented Mar 3, 2018

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to fixed/implemented

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Map Tools Related to non-digitizing map tools labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map Tools Related to non-digitizing map tools
Projects
None yet
Development

No branches or pull requests

1 participant