Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol Selector Window 'overflows' the screen on small resolutions #26704

Closed
qgib opened this issue Apr 28, 2018 · 14 comments
Closed

Symbol Selector Window 'overflows' the screen on small resolutions #26704

qgib opened this issue Apr 28, 2018 · 14 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience

Comments

@qgib
Copy link
Contributor

qgib commented Apr 28, 2018

Author Name: Bien Carlos Manazares (Bien Carlos Manazares)
Original Redmine Issue: 18872
Affected QGIS version: 3.2
Redmine category:gui


At a resolution of 1280x720, the symbol selector window tends to be larger than the screen when the symbol fill type is set to 'SVG Fill', as seen in the picture below. It is impossible to scale the window to fit when the categorization type is set to 'single symbol' or 'categorized'. However, it is possible to scale the window when it overflows if the categorization type is set to 'rule-based'.
image



Related issue(s): #28301 (duplicates)
Redmine related issue(s): 20481


@qgib
Copy link
Contributor Author

qgib commented Apr 28, 2018

Author Name: Harrissou Santanna (@DelazJ)


I think this issue should be fixed by https://github.com/qgis/QGIS/pulls/5976 (switching from a widget to a real resizable dialog); i just need time, some learning and a working build environment to finish it.

@qgib
Copy link
Contributor Author

qgib commented May 9, 2018

Author Name: Harrissou Santanna (@DelazJ)


The fix has been merged in master. Could be nice if you can give it a try and confirm it works so that it gets backported to 3.0. Thanks

@qgib
Copy link
Contributor Author

qgib commented May 9, 2018

Author Name: Bien Carlos Manazares (Bien Carlos Manazares)


Harrissou Santanna wrote:

The fix has been merged in master. Could be nice if you can give it a try and confirm it works so that it gets backported to 3.0. Thanks

How do I do that?

@qgib
Copy link
Contributor Author

qgib commented Aug 28, 2018

Author Name: Harrissou Santanna (@DelazJ)


Sorry to not have replied to you earlier.
Is this issue still available in 3.2?


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Aug 28, 2018

Author Name: Bien Carlos Manazares (Bien Carlos Manazares)


Harrissou Santanna wrote:

Sorry to not have replied to you earlier.
Is this issue still available in 3.2?

Hello. The issue is still present in 3.2. In fact it seems to have worsened, as resizing the window now results in it disappearing completely and locking me out of the program, forcing me to force-quit it via task manager.

@qgib
Copy link
Contributor Author

qgib commented Aug 29, 2018

Author Name: Giovanni Manghi (@gioman)


  • status_id was changed from Feedback to Open
  • category_id was changed from Editing to GUI
  • version was changed from 3.0.2 to 3.2

@qgib
Copy link
Contributor Author

qgib commented Oct 20, 2018

Author Name: Ryan Dalton (@ryankdalton)


This is still a real issue for users of small screens. I'm running into this problem using QGIS 3.2.3 on Windows 10, 14-inch laptop with a max resolution of 1366x768. This is definitely a regression from 2.8. The workaround of using rule-based was successful.

@qgib
Copy link
Contributor Author

qgib commented Oct 26, 2018

Author Name: Hanif Rifai (@hanreev)


Adding QScrollArea as main container or stackedWidget container in qgssymbolselectordialogbase.ui will fix the problem.
I've tested on my custom build.

@qgib
Copy link
Contributor Author

qgib commented Oct 27, 2018

Author Name: Giovanni Manghi (@gioman)


Hanif Rifai wrote:

Adding QScrollArea as main container or stackedWidget container in qgssymbolselectordialogbase.ui will fix the problem.
I've tested on my custom build.

can you propose a pull request?

@qgib
Copy link
Contributor Author

qgib commented Oct 28, 2018

Author Name: Alessandro Sarretta (@alesarrett)


I confirm the issue, just tested in QGIS 3.5.0-Master.
I'm not sure this can help but, while the issue happens with the "Symbol selector" window, it doesn't in the "Edit rule" window, accessed through the menu Properties (see the two short animated gifs attached).
Ale


  • 13616 was configured as windowSize_ok.gif
  • 13615 was configured as windowSize_ko.gif

@qgib
Copy link
Contributor Author

qgib commented Oct 31, 2018

Author Name: Hanif Rifai (@hanreev)


Giovanni Manghi wrote:

can you propose a pull request?

-I need to test it on macos and linux first-

Pull request submitted #8391

@qgib
Copy link
Contributor Author

qgib commented Nov 5, 2018

Author Name: Anónimo (Anónimo)


Applied in changeset cd28b45.


  • status_id was changed from Open to Closed
  • done_ratio was changed from 0 to 100

@qgib qgib closed this as completed Nov 5, 2018
@qgib
Copy link
Contributor Author

qgib commented Nov 14, 2018

Author Name: Ryan Dalton (@ryankdalton)


Confirmed was resolved in 3.5.13 on a on Windows 10, 14-inch laptop with a max resolution of 1366x768. Great work!

@qgib
Copy link
Contributor Author

qgib commented Nov 14, 2018

Author Name: Jürgen Fischer (@jef-n)


@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

No branches or pull requests

1 participant