Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18872 Fix symbol selector dialog overflows the screen on small resolution #8391

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

hanreev
Copy link
Contributor

@hanreev hanreev commented Oct 31, 2018

Description

Fixes #18872

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@DelazJ
Copy link
Contributor

DelazJ commented Nov 1, 2018

hi @hanreev thanks for the fix. Does it scale well also in the layer styling panel? I mean no vertical scroll bar that would unnecessarily shrink the useful width? I remember there was a double scroll bar issue in an old release. Sorry I can't test myself.

@hanreev
Copy link
Contributor Author

hanreev commented Nov 2, 2018

@DelazJ i'm not sure about vertical sroll bar in styling panel. will re-test it today

@hanreev
Copy link
Contributor Author

hanreev commented Nov 2, 2018

Everything works fine on macOS and Windows. Hopefully works on linux too.

  • Layer properties
  • Renderer settings dialog
  • Layer styling panel

macOS 10.13.6

screen shot 2018-11-03 at 06 19 27
screen shot 2018-11-03 at 06 19 57
screen shot 2018-11-03 at 06 22 12

Windows 10

screenshot 72
screenshot 73
screenshot 74

@DelazJ
Copy link
Contributor

DelazJ commented Nov 3, 2018

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants