layer properties dialog does not call widget factory's supportsLayer() method

[qgib]

Author Name: Ricardo Silva (Ricardo Silva)
Original Redmine Issue: 20240
Affected QGIS version: 3.3(master)
Redmine category:vectors

---

Vector layer properties dialogs can be extended by plugin authors by leveraging @QgsMapLayerConfigWidgetFactory@. This class defines the @supportsLayer()@ method, which would be useful for only attaching a custom properties panel if the layer meets some requirements (e.g. if it is a postgis layer). However, this method is never called by @QgsVectorLayerProperties::addPropertiesPageFactory()@, which results in the custom properties panel being shown all the time.

This issue seems fairly easy to fix, as it is just a matter of adding an @if@ clause that checks the result of the factory's @supportsLayer()@ method, similarly to the already existing check for @supportLayerPropertiesDialog@

---

Related issue(s): #28060 (relates)
Redmine related issue(s): 20239

---

[qgib]

Author Name: Ricardo Silva (Ricardo Silva)

---

• relates was configured as Raster layer properties dialog cannot be extended #28060

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

This issue seems fairly easy to fix, as it is just a matter of adding an if clause that checks the result of the factory's supportsLayer() method, similarly to the already existing check for supportLayerPropertiesDialog

Could you please provide a patch or better, a pull-request?

[qgib]

Author Name: Ricardo Silva (Ricardo Silva)

---

Yes, I can supply a PR. I cannot commit to a date, unfortunately, but it should be soon.

[qgib]

Author Name: Ricardo Silva (Ricardo Silva)

---

Applied in changeset a9f7f35.

---

• done_ratio was changed from 0 to 100
• status_id was changed from Open to Closed