Raster layer properties dialog cannot be extended

[qgib]

Author Name: Ricardo Silva (Ricardo Silva)
Original Redmine Issue: 20239
Affected QGIS version: 3.3(master)
Redmine category:rasters

---

The vector layer properties dialog can be extended by calling @QgisInterface.registerMapLayerConfigWidgetFactory()@

Plugin authors can create a class that derives from @QgsMapLayerConfigWidgetFactory@ and implements its virtual methods, especially @createWidget()@ and this allows adding custom panels to the Vector layer properties dialog.

Unfortunately it is not possible to extend the Raster layer properties dialog in this way, which kind of feels more like a bug than a missing feature.

Looking at QGIS' source code, both @QgsRasterLayerProperties@ and @QgsVectorLayerProperties@ inherit from @QgsOptionsDialogBase@, so it seems like moving the code that is currently present in the vector layer properties to the base class would fix this. The relevant method is @QgsVectorLayerProperties::addPropertiesPageFactory()@. This method is only called in @QgisApp::showLayerProperties()@ - currently it is only called for vector layers, but it would be possible to call it also with raster layers

---

Related issue(s): #28061 (relates)
Redmine related issue(s): 20240

---

[qgib]

Author Name: Ricardo Silva (Ricardo Silva)

---

• relates was configured as layer properties dialog does not call widget factory's supportsLayer() method #28061

[qgib]

Author Name: Ricardo Silva (Ricardo Silva)

---

Upon closer inspection, it seems @QgsOptionsDialogBase@ is very generic and is used in lots of places, so this kind of functionality does not seem like it belongs there. Perhaps a new class that derives from @QgsOptionDialogBase@ and is a base for both layer properties dialogs is in order?

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Something like QgsMapLayerPropertiesBase makes sense to me, would you like to make a pull request?

[qgib]

Author Name: Ricardo Silva (Ricardo Silva)

---

Yes, I'm willing to submit a PR. I cannot commit to any date for it though. But I hope to be able to submit it soon :)

[gioman]

@ricardogsilva is this still relevant?

[ricardogsilva]

yes AFAIK the reported issue still exists. I've not been able to produce a PR for it yet. However, Kartoza is currently working on a project where we plan to tackle this.

cc @Samweli

[Samweli]

cc @Samweli

@ricardogsilva @gioman working on a PR for this issue.