Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on apply qml style for a raster layer in 3.4.1 and Master 0ea86bf0a5 #28229

Closed
qgib opened this issue Nov 8, 2018 · 19 comments · Fixed by #38083
Closed

Error on apply qml style for a raster layer in 3.4.1 and Master 0ea86bf0a5 #28229

qgib opened this issue Nov 8, 2018 · 19 comments · Fixed by #38083
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers

Comments

@qgib
Copy link
Contributor

qgib commented Nov 8, 2018

Author Name: Antonio Viscomi (@Antoviscomi)
Original Redmine Issue: 20409
Affected QGIS version: 3.4.1
Redmine category:symbology


New description:

After loading a saved QML style, this changes to a different one when clicking on "apply". Data, style and screencast attached.

Old description:
in 2.18.25 it works fine with the same data and qml
in 3.4.1 and Master 0ea86bf it don't works
I attach a screencast, data and qml file


@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Giovanni Manghi (@gioman)


was the qml created in 2.18?


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


Giovanni Manghi wrote:

was the qml created in 2.18?

yes
I also noticed that, when I load a qml in 3.4.1 an Master (regardless of whether it was created with 3.4, 3.5 or 2.x) ,
"visualization type" It automatically switch on "palette"
even if the style had been saved in pseudo color mode

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Giovanni Manghi (@gioman)


I also noticed that, when I load a qml in 3.4.1 an Master (regardless of whether it was created with 3.4, 3.5 or 2.x) ,
"visualization type" It automatically switch on "palette"
even if the style had been saved in pseudo color mode

this is a different issue (I think) please file a different ticket (with sample data and style), thanks.

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Giovanni Manghi (@gioman)


I also noticed that, when I load a qml in 3.4.1 an Master (regardless of whether it was created with 3.4, 3.5 or 2.x) ,
"visualization type" It automatically switch on "palette"
even if the style had been saved in pseudo color mode

just tried this in qgis master and can't confirm.

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Giovanni Manghi (@gioman)


  • regression was changed from 1 to 0
  • operating_system was changed from windows 7 to
  • description was changed from in 2.18.25 it works fine with the same data and qml
    in 3.4.1 and Master 0ea86bf it don't works
    I attach a screencast, data and qml file to New description:

After loading a saved QML style, this changes to a different one when clicking on "apply". Data, style and screencast attached.

Old description:
in 2.18.25 it works fine with the same data and qml
in 3.4.1 and Master 0ea86bf it don't works
I attach a screencast, data and qml file

  • status_id was changed from Feedback to Open
  • priority_id was changed from High to Normal

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Martin Dobias (@wonder-sk)


I think this a consequence of removal of the "Load" button to load min/max values from raster layer properties in #3871 - it was changed to load min/max when Apply is clicked which I think here interferes with the newly loaded style (once the new min/max values are loaded, the classification is auto-updated from the current color ramp). My preference would be to have the "Load" button back so it is not tied to Apply which is somehow unexpected.

side tip: after loading QML style, you do not need to click Apply or OK. Just press Cancel button and the loaded style should stay... hard to say whether that's a bug or a feature :-)

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Giovanni Manghi (@gioman)


Martin Dobias wrote:

I think this a consequence of removal of the "Load" button to load min/max values from raster layer properties in #3871 - it was changed to load min/max when Apply is clicked which I think here interferes with the newly loaded style (once the new min/max values are loaded, the classification is auto-updated from the current color ramp). My preference would be to have the "Load" button back so it is not tied to Apply which is somehow unexpected.

+1

side tip: after loading QML style, you do not need to click Apply or OK. Just press Cancel button and the loaded style should stay... hard to say whether that's a bug or a feature :-)

... is at the very minimum a very bad ux, borderline bug.

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


Martin Dobias wrote:

side tip: after loading QML style, you do not need to click Apply or OK. Just press Cancel button and the loaded style should stay... hard to say whether that's a bug or a feature :-)

is not to contradict you but if I press close button appear what you see in the screencast named qml_style2


  • 13715 was configured as qml_style2.avi

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


Giovanni Manghi wrote:

I also noticed that, when I load a qml in 3.4.1 an Master (regardless of whether it was created with 3.4, 3.5 or 2.x) ,
"visualization type" It automatically switch on "palette"
even if the style had been saved in pseudo color mode

this is a different issue (I think) please file a different ticket (with sample data and style), thanks.

I think is not a issue but the prefixed behavior for new style manager

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


Giovanni Manghi wrote:

I also noticed that, when I load a qml in 3.4.1 an Master (regardless of whether it was created with 3.4, 3.5 or 2.x) ,
"visualization type" It automatically switch on "palette"
even if the style had been saved in pseudo color mode

just tried this in qgis master and can't confirm.

the screencasts was recorded on Master 8125366

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Giovanni Manghi (@gioman)


the screencasts was recorded on Master 8125366

I'm referring to the second issue, the one that is not part of the description of this ticket (you added as a comment).

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


Giovanni Manghi wrote:

the screencasts was recorded on Master 8125366

I'm referring to the second issue, the one that is not part of the description of this ticket (you added as a comment).

ah ok,
then I need to refile the second one as a new Issue?

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


Antonio Viscomi wrote:

New description:

After loading a saved QML style, this changes to a different one when clicking on "apply". Data, style and screencast attached.

I attach the qml saved by Master


  • 13716 was configured as sl_raster_rec_350.qml

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Giovanni Manghi (@gioman)


I attach the qml saved by Master

is not a matter of qml, explanation has been give here in #28229 (comment)

@qgib
Copy link
Contributor Author

qgib commented Nov 9, 2018

Author Name: Giovanni Manghi (@gioman)


ah ok,
then I need to refile the second one as a new Issue?

you sure about it? I can't confirm here.

@qgib
Copy link
Contributor Author

qgib commented Nov 9, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


Giovanni Manghi wrote:

ah ok,
then I need to refile the second one as a new Issue?

you sure about it? I can't confirm here.

Yes, I do
Because in screencast qml_style2 it appear this... But I'm not sure It is an issue

@qgib
Copy link
Contributor Author

qgib commented Nov 9, 2018

Author Name: Giovanni Manghi (@gioman)


Yes, I do
Because in screencast qml_style2 it appear this... But I'm not sure It is an issue

the only issue I see (in your cast) is that when loading the style it is applied correclty it does not switch to "palletted". If you close the properties and reopen them it shows correctly "palletted", is it?

@qgib
Copy link
Contributor Author

qgib commented Nov 9, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


Giovanni Manghi wrote:

Yes, I do
Because in screencast qml_style2 it appear this... But I'm not sure It is an issue

the only issue I see (in your cast) is that when loading the style it is applied correclty it does not switch to "palletted". If you close the properties and reopen them it shows correctly "palletted", is it?

Yes, even if the style is saved by 3.5 in pseudocolor mode when you load it or open it again It automatically switches to palette

@qgib
Copy link
Contributor Author

qgib commented Nov 29, 2018

Author Name: Antonio Viscomi (@Antoviscomi)


this issue appears even in the case of a reclassification of a raster making vain the same reclassification

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers
Projects
None yet
1 participant