Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGIS3.4 Organize columns, data integrity compromised #28493

Closed
qgib opened this issue Nov 29, 2018 · 19 comments
Closed

QGIS3.4 Organize columns, data integrity compromised #28493

qgib opened this issue Nov 29, 2018 · 19 comments
Labels
Attribute Table Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption High Priority

Comments

@qgib
Copy link
Contributor

qgib commented Nov 29, 2018

Author Name: Soares SOares (Soares SOares)
Original Redmine Issue: 20673
Affected QGIS version: 3.5(master)
Redmine category:attribute_table
Assignee: Julien Cabieces


When you use 'Organize columns' and 'move selection to top' in atribute table you can crash your data integrity.

To reproduce this bug you will need a layer with more than 14 columns and more than
45 rows. That is the specification of our smaler table. We have tried with
a smaller table and we don't get any error.

1 - pick up the atribute table (postgres with geometry or shapefile),
right click in a column name and select 'Organize columns...'
2 - Reorder the columns. Thinking in column position like a list, try a
sequence that bring to initial positions the end elements. In a example
14,12,5,1,2...
3 - Back to the table, start edition.
4 - Click at QGIS numerator of feature in table. this will turn editable the cell of
the column 14 (remind the example above),
5 - Chose in menu table 'move selection to top'
6 - look for the atribute's of column 14, it will apear in another column
of the same selected object.



Related issue(s): #28553 (relates)
Redmine related issue(s): 20733


@qgib
Copy link
Contributor Author

qgib commented Nov 29, 2018

Author Name: Giovanni Manghi (@gioman)


Does it happens on 2.18?


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Nov 29, 2018

Author Name: Soares SOares (Soares SOares)


Yes, Giovanni. And also in 3.4LTR

@qgib
Copy link
Contributor Author

qgib commented Nov 29, 2018

Author Name: Giovanni Manghi (@gioman)


Soares SOares wrote:

Yes, Giovanni. And also in 3.4LTR

my question was about 2.18, not 3.4

@qgib
Copy link
Contributor Author

qgib commented Nov 29, 2018

Author Name: Soares SOares (Soares SOares)


Yes, it happens in 2.18.

@qgib
Copy link
Contributor Author

qgib commented Nov 29, 2018

Author Name: Giovanni Manghi (@gioman)


Soares SOares wrote:

Yes, it happens in 2.18.

I assume that the raw data integrity is not compromised(?)


  • priority_id was changed from High to Normal
  • crashes_corrupts_data was changed from 1 to 0

@qgib
Copy link
Contributor Author

qgib commented Nov 30, 2018

Author Name: Alessandro Pasotti (@elpaso)


I cannot reproduce on current master, can you please add a sample project and sample data and a video that demonstrate the issue?

@qgib
Copy link
Contributor Author

qgib commented Nov 30, 2018

Author Name: Soares SOares (Soares SOares)


Ok, I will send to you on monday.

@qgib
Copy link
Contributor Author

qgib commented Dec 3, 2018

Author Name: Soares SOares (Soares SOares)


Hello Alessandro. At the moment I can't make a video, but there is a project with a shapefile.
The columns already have been organized, so after open the project:

  • Open attribute table;
  • Start edition;
  • Select any feature (click on QGIS's numerator in table);
  • Move selection to top.

The content atribute in selected cell (col_18) will be sended to 'col_11'


  • 13894 was configured as sample_data.zip

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2018

Author Name: Soares SOares (Soares SOares)


2.14 just fine

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2018

Author Name: Alessandro Pasotti (@elpaso)


Confirmed on master thanks for the demo data.


  • version was changed from 3.4.2 to 3.5(master)

@qgib
Copy link
Contributor Author

qgib commented Dec 6, 2018

Author Name: Alessandro Pasotti (@elpaso)


@qgib
Copy link
Contributor Author

qgib commented Dec 6, 2018

Author Name: Giovanni Manghi (@gioman)


  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Dec 6, 2018

Author Name: Luigi Pirelli (@luipir)


is it confirmed data loss or compromising? if so, the issue shouldn't have normal priority

@qgib
Copy link
Contributor Author

qgib commented Dec 7, 2018

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Normal to High
  • crashes_corrupts_data was changed from 0 to 1

@qgib
Copy link
Contributor Author

qgib commented Dec 20, 2018

Author Name: Julien Cabieces (Julien Cabieces)


Proposed PR : #8725

@qgib
Copy link
Contributor Author

qgib commented Dec 20, 2018

Author Name: Luigi Pirelli (@luipir)


please Soares SOares give a double check to the proposed PR if it's possible. otherwise you have to wait merge and nightly build

Julien Cabieces wrote:

Proposed PR : #8725

@qgib
Copy link
Contributor Author

qgib commented Dec 22, 2018

Author Name: Julien Cabieces (Julien Cabieces)


Applied in changeset fba4b25.


  • status_id was changed from Open to Closed
  • done_ratio was changed from 0 to 100

@qgib
Copy link
Contributor Author

qgib commented Jan 21, 2019

Author Name: Soares SOares (Soares SOares)


I've Tested 2.18.27 and the bug still there. The bug also persists in 3.4.3 I've used the same file in bug report.


  • status_id was changed from Closed to Reopened
  • assigned_to_id was configured as Julien Cabieces

@qgib
Copy link
Contributor Author

qgib commented Jan 21, 2019

Author Name: Julien Cabieces (Julien Cabieces)


The correction had not been backported in 2.18.27 but is present in 3.4.4 (not 3.4.3)


  • status_id was changed from Reopened to Closed
  • resolution was changed from to fixed/implemented

@qgib qgib closed this as completed Jan 21, 2019
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Attribute Table Crash/Data Corruption labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attribute Table Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption High Priority
Projects
None yet
Development

No branches or pull requests

1 participant