Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mapFromSource method when reordering columns. fixes #20673 #8725

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

troopa81
Copy link
Contributor

Description

This PR corrects the issue https://issues.qgis.org/issues/20673
When we reorder column (last column becomes first column for instance) with select on top activated, and we select an entire row the currentIndex is no longer the first column, and consequently it breaks edition.

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@luipir luipir changed the title fixes #20673 : Correct mapFromSource method when reordering columns Correct mapFromSource method when reordering columns. fixes #20673 Dec 20, 2018
@m-kuhn
Copy link
Member

m-kuhn commented Dec 22, 2018

Thanks a lot.
Once the fix is confirmed, a backport will be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants