Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hillshade Layer Style wrong if OpenCL acceleration is enabled #28939

Closed
qgib opened this issue Jan 29, 2019 · 13 comments
Closed

Hillshade Layer Style wrong if OpenCL acceleration is enabled #28939

qgib opened this issue Jan 29, 2019 · 13 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Rasters Related to general raster layer handling (not specific data formats)

Comments

@qgib
Copy link
Contributor

qgib commented Jan 29, 2019

Author Name: luca bellani (luca bellani)
Original Redmine Issue: 21121
Affected QGIS version: 3.5(master)
Redmine category:rasters
Assignee: Alessandro Pasotti


Hello. I noticed that with certain DEM (not all), QGIS 3.4.4 generates a display problem in the "hillshade" style.
Only in the layer style, because the GDAL geo-process works perfectly.


@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: luca bellani (luca bellani)


  • 14193 was configured as dem_prueba.tif

@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: Alessandro Pasotti (@elpaso)


I think it's a know issue and there is not much we can do, did you try to adjust the "Resampling" parameters in the renderer configuration?


  • status_id was changed from Open to Feedback
  • assigned_to_id was configured as Alessandro Pasotti
  • operating_system was changed from Windows 10 64 bit v. 1809 to Any
  • priority_id was changed from High to Normal
  • version was changed from 3.4.4 to 3.5(master)

@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: luca bellani (luca bellani)


Salve. What is strange to me, is that in QGIS 2.18 it does not give any problem.
And it seems to be something random. In QGIS 3.4.4, I loaded the DEM again, and adjust the "Resampling" parameters "bilineal", and now all is ok.

@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: Alessandro Pasotti (@elpaso)


I think it depends on the zoom level too.

@qgib
Copy link
Contributor Author

qgib commented Jan 30, 2019

Author Name: Giovanni Manghi (@gioman)


Alessandro Pasotti wrote:

I think it's a know issue and there is not much we can do, did you try to adjust the "Resampling" parameters in the renderer configuration?

closing then?

@qgib
Copy link
Contributor Author

qgib commented Jan 30, 2019

Author Name: luca bellani (luca bellani)


I have reviewed other DEMs that gave me problems, and as can be seen in the comparative image, the problem is presented in QGIS 3, not in QGIS 2. I have already completely manipulated the resampling options, but it is not solved.
It's funny that it's a bug, but only in the new version of QGIS.
Annex also another DEM, so that they can prove it.
Thanks for the support.


  • 14212 was configured as comparacion.png
  • 14213 was configured as DEM_prova2.rar

@qgib
Copy link
Contributor Author

qgib commented Jan 30, 2019

Author Name: Alessandro Pasotti (@elpaso)


Out of curiosity: are you using OpenCL acceleration? If yes can you try to disable it?

@qgib
Copy link
Contributor Author

qgib commented Jan 30, 2019

Author Name: luca bellani (luca bellani)


Yes! That's the reason!
Deactivating OpenGl and always putting the resampling in "bilinear" is displayed correctly.
Thank you!

@qgib
Copy link
Contributor Author

qgib commented Jan 30, 2019

Author Name: Giovanni Manghi (@gioman)


  • subject was changed from Error Hillshade Layer Style to Hillshade Layer Style wrong if OpenCL acceleration is enabled
  • status_id was changed from Feedback to Open
  • operating_system was changed from Any to

@qgib
Copy link
Contributor Author

qgib commented Jan 31, 2019

Author Name: Alessandro Pasotti (@elpaso)


Luca, can you please make a quick test with OpenCL activated and tell me if it works with the sampling bilinear option or if it does not?
If it does not work, can you please have a look to the QGIS messages (small icon at the bottom right) in the OpenCL section?
Also, please paste a picture of the OpenCL tab in your settings or copy-paste the information about your OpenCL device.

@qgib
Copy link
Contributor Author

qgib commented Feb 1, 2019

Author Name: luca bellani (luca bellani)


I did the tests. When you activate OpenCl, even if you change the type of resampling, it is displayed incorrectly.
In the message window, I do not see the OpenCl tab, I do not know if I have something wrong installed. Annex images.
Thank you


  • 14229 was configured as 1.PNG
  • 14230 was configured as 3.PNG

  • 1.PNG (luca bellani) - opencl tab
  • 3.PNG (luca bellani) - bilineal hillshade style wrong

@qgib
Copy link
Contributor Author

qgib commented Feb 2, 2019

Author Name: Alessandro Pasotti (@elpaso)


PR #9070

I'd like you to test if this patch solves your issue (with OpenCL ativated).


  • status_id was changed from Open to In Progress
  • category_id was changed from Symbology to Rasters
  • pull_request_patch_supplied was changed from 0 to 1

@qgib
Copy link
Contributor Author

qgib commented Feb 4, 2019

Author Name: Alessandro Pasotti (@elpaso)


Applied in changeset 1aef9cf.


  • status_id was changed from In Progress to Closed
  • done_ratio was changed from 0 to 100

@qgib qgib closed this as completed Feb 4, 2019
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Rasters Related to general raster layer handling (not specific data formats) labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Rasters Related to general raster layer handling (not specific data formats)
Projects
None yet
Development

No branches or pull requests

1 participant