Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapping tooltips + advanced digitizing QGIS not responding #28962

Closed
qgib opened this issue Jan 31, 2019 · 22 comments · Fixed by #30269
Closed

Snapping tooltips + advanced digitizing QGIS not responding #28962

qgib opened this issue Jan 31, 2019 · 22 comments · Fixed by #30269
Assignees
@3nids
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Digitizing Related to feature digitizing map tools or functionality High Priority Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Jan 31, 2019

Author Name: Nikolai Krawczak (Nikolai Krawczak)
Original Redmine Issue: 21144
Affected QGIS version: 3.7(master)
Redmine category:digitising

A combination of snapping tooltips and advanced digitizing is not working. QGIS becomes unresponsive.
!snapping_info.gif!
@qgib
Copy link
Contributor Author

qgib commented Jan 31, 2019

Author Name: Jan Lippmann (@j-lippmann)

I can confirm. same issue today in my workshop...

@qgib
Copy link
Contributor Author

qgib commented Jan 31, 2019

Author Name: Giovanni Manghi (@gioman)

Also on a new/clean profile (no 3rd party plugins installed)?

  • status_id was changed from Open to Feedback
  • priority_id was changed from Normal to High

@qgib
Copy link
Contributor Author

qgib commented Jan 31, 2019

Author Name: Nikolai Krawczak (Nikolai Krawczak)

Giovanni Manghi wrote:

Also on a new/clean profile (no 3rd party plugins installed)?

yes, I used a fresh profile for confirmation.

@qgib
Copy link
Contributor Author

qgib commented Jan 31, 2019

Author Name: Nyall Dawson (@nyalldawson)

I can't reproduce on Linux -- possible windows specific?

@qgib
Copy link
Contributor Author

qgib commented Feb 1, 2019

Author Name: Nikolai Krawczak (Nikolai Krawczak)

Nyall Dawson wrote:

I can't reproduce on Linux -- possible windows specific?

maybe even windows version specific - I can't reproduce on Win 10

@qgib
Copy link
Contributor Author

qgib commented Feb 1, 2019

Author Name: Jan Lippmann (@j-lippmann)

In my case, it's an issue on Win 7 64 bit. Also with actual master.

@qgib
Copy link
Contributor Author

qgib commented Feb 2, 2019

Author Name: Jan Lippmann (@j-lippmann)

I can confirm with NO issue on Linux...

@qgib
Copy link
Contributor Author

qgib commented Feb 12, 2019

Author Name: Almerio Moreira (@jorgealmerio)

I CAN confirm same issue with Windows 7 Professional 64 bits!

@qgib
Copy link
Contributor Author

qgib commented Feb 12, 2019

Author Name: Urs Kaufmann (Urs Kaufmann)

I can confirm on Win 7 Prof, I can not confirm on Mac OS 10.14.3
But on both systems, QGIS crashes on exit, if I before used advanced digitizing and enabled snapping together

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Giovanni Manghi (@gioman)

But on both systems, QGIS crashes on exit, if I before used advanced digitizing and enabled snapping together

even on a new/clean profile (no 3rd party plugins installed)?

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Almerio Moreira (@jorgealmerio)

even on a new/clean profile (no 3rd party plugins installed)?

On a new/clean profile it worked fine on Windows 7, but I got the following issue on close:

Crash ID: 951373503a103ea02a4b994f442bf9beef9027b4

Stack Trace

QgsSnapIndicator::~QgsSnapIndicator :
QgsAdvancedDigitizingCanvasItem::~QgsAdvancedDigitizingCanvasItem :
QgsAdvancedDigitizingDockWidget::CadConstraint::operator= :
QgsMapCanvas::~QgsMapCanvas :
QgsVectorLayerProperties::`default constructor closure' :
QgisApp::~QgisApp :
CPLStringList::operator[] :
main :
BaseThreadInitThunk :
RtlUserThreadStart :

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Urs Kaufmann (Urs Kaufmann)

But on both systems, QGIS crashes on exit, if I before used advanced digitizing and enabled snapping together

even on a new/clean profile (no 3rd party plugins installed)?

Yes, the crash is also on a new profile

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Giovanni Manghi (@gioman)

  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Giovanni Manghi (@gioman)

Almerio Moreira wrote:

even on a new/clean profile (no 3rd party plugins installed)?

On a new/clean profile it worked fine on Windows 7, but I got the following issue on close:

so the issue described here does not show on a new/clean profile?
the crash on exit is probably unrelated, and there are a ton of other similar reports about it.

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Giovanni Manghi (@gioman)

  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Jan Lippmann (@j-lippmann)

i can confirm nikolai..

its an issue on a new/clean profile (no 3rd party plugins installed!) AND WIN 7!

there is no crash with the crashreport window...qgis freeze/hang and takes cpu time and eat's ram while hanging...

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Almerio Moreira (@jorgealmerio)

Giovanni Manghi wrote:

Almerio Moreira wrote:

even on a new/clean profile (no 3rd party plugins installed)?

On a new/clean profile it worked fine on Windows 7, but I got the following issue on close:

so the issue described here does not show on a new/clean profile?
the crash on exit is probably unrelated, and there are a ton of other similar reports about it.

I have no problem with a clean profile on Win 7, but this Crash on exit is for sure related to the combination of advanced digitizing and enabled snapping together, as you can see on stack trace I posted on #11 and for many tests I did.

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Giovanni Manghi (@gioman)

  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Feb 13, 2019

Author Name: Urs Kaufmann (Urs Kaufmann)

My experience: the effect of the clean profile is, that the "show snapping tooltips" is off (as shown in the video above). If I turn on and off these snapping tooltips in "old" profiles I can control the freezing (so turn it off). But I can not control the crash on exit QGIS...

@qgib
Copy link
Contributor Author

qgib commented Feb 14, 2019

Author Name: Almerio Moreira (@jorgealmerio)

Urs Kaufmann wrote:

My experience: the effect of the clean profile is, that the "show snapping tooltips" is off (as shown in the video above). If I turn on and off these snapping tooltips in "old" profiles I can control the freezing (so turn it off). But I can not control the crash on exit QGIS...

Yes, you are right!!!
By turning off snapping tooltips it works good even with "Dirty" profile!
But the crash on exit continues

@qgib
Copy link
Contributor Author

qgib commented Mar 1, 2019

Author Name: Jochen Schwarze (Jochen Schwarze)

Observed the same issue with 3.4.5 LTR(!), 3.6.0 and 3.7.0 on WIN 10, no 3rd party plugins installed.

@qgib
Copy link
Contributor Author

qgib commented Mar 1, 2019

Author Name: Giovanni Manghi (@gioman)

  • version was changed from 3.4.4 to 3.7(master)
  • regression was changed from 0 to 1

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Digitizing Related to feature digitizing map tools or functionality Crash/Data Corruption Regression Something which used to work, but doesn't anymore labels May 25, 2019
@urskaufmann urskaufmann mentioned this issue Jun 6, 2019
Closed
@3nids 3nids self-assigned this Jun 19, 2019
@3nids 3nids mentioned this issue Jun 19, 2019
Merged
3nids added a commit to 3nids/QGIS that referenced this issue Jun 19, 2019
@3nids
do not use unique_ptr for QGraphicsItem
9c76524 
since the ownership of the item is transferred to the scene
this leads to a crash when deleting the object holding the pointer

since the ownership is transferred back when removing the item, one should
take care of resetting the pointer no canvas deletion

this should fix qgis#28962
@3nids 3nids mentioned this issue Jun 19, 2019
Closed
backporting bot pushed a commit that referenced this issue Jun 20, 2019
@3nids
do not use unique_ptr for QGraphicsItem
2f7ca05 
since the ownership of the item is transferred to the scene
this leads to a crash when deleting the object holding the pointer

since the ownership is transferred back when removing the item, one should
take care of resetting the pointer no canvas deletion

this should fix #28962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3nids 3nids

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Digitizing Related to feature digitizing map tools or functionality High Priority Regression Something which used to work, but doesn't anymore
Projects
None yet
Milestone
No milestone
2 participants
@3nids @qgib