Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues and deadlocks with WFS #29258

Closed
qgib opened this issue Mar 1, 2019 · 9 comments
Closed

Multiple issues and deadlocks with WFS #29258

qgib opened this issue Mar 1, 2019 · 9 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers High Priority Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Mar 1, 2019

Author Name: Alessandro Pasotti (@elpaso)
Original Redmine Issue: 21441
Affected QGIS version: 3.7(master)
Redmine category:web_services_clients/wfs
Assignee: Nyall Dawson


I've tested several scenarios and they all works fine and fast with QGIS 2.18.

to reproduce:

git checkout https://github.com/elpaso/qgis3-server-vagrant.git
cd qgis3-server-vagrant
vagrant up

There is a configured project in the resource/qgis folder: https://github.com/elpaso/qgis3-server-vagrant/tree/master/resources/qgis

Issues:

  • Timeout when loading the features layer "world" with all deployment methods (apache 8081, ngix 8080 and wgsi 8082), tested with ab concurrent and got no issues at all: fast and reliable
  • Partial download of the features
  • The a.m. vagrant has a HTTP Basic auth configuration username=username and password=password, but I tested also a configuration without HTTP auth and the issues are still there.

I've also observed deadlock in qgswfsrequest.cpp line 206 - waitCondition.wait( &waitConditionMutex ); when opening another WFS from metasearch catalog window.


Related issue(s): #27626 (relates)
Redmine related issue(s): 19801


@qgib
Copy link
Contributor Author

qgib commented Mar 1, 2019

Author Name: Alessandro Pasotti (@elpaso)


btw, 3.4 has the same issues

@qgib
Copy link
Contributor Author

qgib commented Mar 1, 2019

Author Name: Giovanni Manghi (@gioman)


I can confirm that WFS works in a very inconsistent way now on 3.4.5 and above.


  • priority_id was changed from Normal to High

@qgib
Copy link
Contributor Author

qgib commented Mar 8, 2019

Author Name: Jacob Madsen (Jacob Madsen)


Giovanni Manghi wrote:

I can confirm that WFS works in a very inconsistent way now on 3.4.5 and above.

I can confirm these issues as well. I've had to stick with QGIS 2.x so far, because since QGIS 3.0 WFS in QGIS is next to unusable. I really hope these issues can be fixed soon. I can confirm that these issues are not present in QGIS 2.18.

@qgib
Copy link
Contributor Author

qgib commented Mar 8, 2019

Author Name: Giovanni Manghi (@gioman)


@qgib
Copy link
Contributor Author

qgib commented Mar 8, 2019

Author Name: Giovanni Manghi (@gioman)


see also #27626

@qgib
Copy link
Contributor Author

qgib commented Mar 8, 2019

Author Name: Giovanni Manghi (@gioman)


We made some test with a service (mapserver is the backend) that do not need authentication.
The real difference seems depends on the "enable paging" option, if not used things seems to work as expected.

@qgib
Copy link
Contributor Author

qgib commented Mar 11, 2019

Author Name: Nyall Dawson (@nyalldawson)


Caused by 0addae5 - changing READ_BUFFER_SIZE_HINT to 0 (unlimited) fixes the issue (likely at resurrecting the original issue fixed by that commit (which I can't track -- it has the incorrect issue number of #11930, I suspect there's a missing digit here).

@qgib
Copy link
Contributor Author

qgib commented Mar 11, 2019

Author Name: Nyall Dawson (@nyalldawson)


  • assigned_to_id was configured as Nyall Dawson

@qgib
Copy link
Contributor Author

qgib commented Mar 11, 2019

Author Name: Alessandro Pasotti (@elpaso)


I can confirm that reverting 0addae5 fixes this issue.

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Data Provider Related to specific vector, raster or mesh data providers Regression Something which used to work, but doesn't anymore labels May 25, 2019
rouault added a commit to rouault/QGIS that referenced this issue May 30, 2019
 qgis#27626)

This apparently caused deadlock issues.

Credit to @nyalldawson for spotting the offending commit.

Partial revert of 0addae5
backporting bot pushed a commit that referenced this issue May 30, 2019
…27626)

This apparently caused deadlock issues.

Credit to @nyalldawson for spotting the offending commit.

Partial revert of 0addae5
nyalldawson pushed a commit that referenced this issue May 30, 2019
…27626)

This apparently caused deadlock issues.

Credit to @nyalldawson for spotting the offending commit.

Partial revert of 0addae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers High Priority Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant