Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't change value in vertex editor if "locale" settings use commas as decimal separator #29682

Closed
qgib opened this issue Apr 17, 2019 · 34 comments · Fixed by #37135 or #41082
Closed

can't change value in vertex editor if "locale" settings use commas as decimal separator #29682

qgib opened this issue Apr 17, 2019 · 34 comments · Fixed by #37135 or #41082
Assignees
@elpaso
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality

Comments

@qgib
Copy link
Contributor

qgib commented Apr 17, 2019 •
edited
Loading

Author Name: Giovanni Manghi (@gioman)
Original Redmine Issue: 21867
Affected QGIS version: 3.6.1
Redmine category:digitising

if you have a locale that uses commas as decimal separator then manually editing values in the vertex editor does not work. Workaround: set QGIS locale to English.

Related issue(s): #29811 (duplicates)
Redmine related issue(s): 21996
@qgib
Copy link
Contributor Author

qgib commented May 5, 2019 •
edited
Loading

Author Name: Giovanni Manghi (@gioman)

@qgib
Copy link
Contributor Author

qgib commented May 10, 2019

Author Name: Giovanni Manghi (@gioman)

  • subject was changed from can't change value in vertex editor if "locale" settings use comms as decimal separator to can't change value in vertex editor if "locale" settings use commas as decimal separator

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality labels May 25, 2019
@qgib qgib mentioned this issue May 25, 2019
Closed
@EcoMiksi
Copy link

This issue is also present in 3.4.7

@gioman gioman mentioned this issue Oct 10, 2019
Closed
@gioman gioman mentioned this issue Nov 11, 2019
Closed
@Xeenych
Copy link

Xeenych commented Nov 11, 2019

This is also present in 3.10.0

@gioman gioman mentioned this issue Jun 11, 2020
Closed
@elpaso elpaso self-assigned this Jun 11, 2020
elpaso added a commit to elpaso/QGIS that referenced this issue Jun 11, 2020
@elpaso
Fix editor vertex with "non-dot" locales
ab149e1 
Fixes qgis#29682
@elpaso elpaso mentioned this issue Jun 11, 2020
Merged
nyalldawson pushed a commit to nyalldawson/QGIS that referenced this issue Jun 15, 2020
@elpaso @nyalldawson
Fix editor vertex with "non-dot" locales
899f18f 
Fixes qgis#29682

(cherry picked from commit ab149e1)
nyalldawson pushed a commit that referenced this issue Jun 19, 2020
@elpaso @nyalldawson
Fix editor vertex with "non-dot" locales
4faea48 
Fixes #29682

(cherry picked from commit ab149e1)
@SrNetoChan
Copy link
Member

@elpaso I am still seeing this problem both in QGIS 3.10 and master. Can we reopen this please?

@SrNetoChan
Copy link
Member

Peek 2020-09-17 22-21

@gioman gioman reopened this Sep 17, 2020
@elpaso
Copy link
Contributor

elpaso commented Jan 19, 2021

@SrNetoChan @gioman I cannot reproduce on current master, I can change and set values in vertex editor correctly using , as a decimal separator.

My locale is IT_it as:

immagine

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

I cannot reproduce on current master, I can change and set values in vertex editor correctly using , as a decimal separator.

@elpaso in what language is your OS?

@elpaso
Copy link
Contributor

elpaso commented Jan 19, 2021

I cannot reproduce on current master, I can change and set values in vertex editor correctly using , as a decimal separator.

@elpaso in what language is your OS?

Does it matter? Italian BTW.

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

Does it matter?

@elpaso I'm checking, I don't want to overlook anything.

@SrNetoChan
Copy link
Member

What decimal separator is normally used in it?

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

What decimal separator is normally used in it?

@SrNetoChan in the vertex editor panel? the dot.

@elpaso
Copy link
Contributor

elpaso commented Jan 19, 2021

What decimal separator is normally used in it?

There is no "normality" here, you are supposed to use the decimal separator that is defined by your current locale (overridden or inherited from the os).

@SrNetoChan
Copy link
Member

Sorry, I meant in italy. Let me recheck this with master.

@elpaso
Copy link
Contributor

elpaso commented Jan 19, 2021

@SrNetoChan , (or the test would have been pointless).

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

Does it matter? Italian BTW.

@elpaso works fine on master with PT_PT locale set at QGIS level on a system with the OS in EN, but let me check on a system with the OS in pt_pt

@SrNetoChan
Copy link
Member

Does your data as Z values? I was testing on QGIS 3.10.14 and I can only replicate the problem when I try to edit the Z values
X and Y work just fine.

@SrNetoChan
Copy link
Member

@elpaso and @gioman are you trying to edit the Z values? those are the ones problematic to me in QGIS 3.10.14 .

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021 •
edited
Loading

@elpaso and @gioman are you trying to edit the Z values? those are the ones problematic to me in QGIS 3.10.14 .

@SrNetoChan checking...

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

@elpaso and @gioman are you trying to edit the Z values? those are the ones problematic to me in QGIS 3.10.14 .

@SrNetoChan works fine with pt_pt as QGIS locale on QGIS master and OS in EN. I'm also checking on a OS in pt_pt.

@SrNetoChan
Copy link
Member

Ok, let me try master in here.

@elpaso
Copy link
Contributor

elpaso commented Jan 19, 2021

@elpaso and @gioman are you trying to edit the Z values? those are the ones problematic to me in QGIS 3.10.14 .

I have an r and no z , r cols are all empty.

Do you have a test project and data to reproduce the z issue?

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

Do you have a test project and data to reproduce the z issue?

@elpaso testing ongoing... ;)

@SrNetoChan
Copy link
Member

@elpaso and @gioman are you trying to edit the Z values? those are the ones problematic to me in QGIS 3.10.14 .

I have an r and no z , r cols are all empty.

Do you have a test project and data to reproduce the z issue?

give one sec.

@SrNetoChan
Copy link
Member

Temp.zip

@SrNetoChan
Copy link
Member

I don't think it's only the OS Language, but the locale settings. That is, if the OS Language is English, but the regional settings (time, currency, and so on) are in PT_pt, I get this problem.

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

That is, if the OS Language is English, but the regional settings (time, currency, and so on) are in PT_pt,

@SrNetoChan in QGIS or at a OS level?

@SrNetoChan
Copy link
Member

OS

@elpaso
Copy link
Contributor

elpaso commented Jan 19, 2021

@gioman just to be clear: OS settings are just the default, when you check "[x] override ..." QGIS is in command.

@SrNetoChan
Copy link
Member

OS

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

Temp.zip

@SrNetoChan @elpaso all ok here on QGIS master on OS in pt_pt with or without the QGIS locale set to pt_pt.

@elpaso
Copy link
Contributor

elpaso commented Jan 19, 2021

@SrNetoChan confirmed with Z

@gioman
Copy link
Contributor

gioman commented Jan 19, 2021

confirmed with Z

@elpaso weird, not here.

@elpaso
Copy link
Contributor

elpaso commented Jan 19, 2021

@gioman fixed, PR is on the way.

elpaso added a commit to elpaso/QGIS that referenced this issue Jan 19, 2021
@elpaso
Fix vertex editor locale with Z/R values
e859d44 
Fixes qgis#29682
@elpaso elpaso mentioned this issue Jan 19, 2021
Merged
nyalldawson pushed a commit that referenced this issue Jan 19, 2021
@elpaso @nyalldawson
Fix vertex editor locale with Z/R values
9b6d2eb 
Fixes #29682
elpaso added a commit to elpaso/QGIS that referenced this issue Feb 17, 2021
@elpaso
Fix vertex editor locale with Z/R values
4501369 
Fixes qgis#29682

Manual backport of master commit e859d44
@elpaso elpaso mentioned this issue Feb 17, 2021
Closed
nyalldawson pushed a commit to nyalldawson/QGIS that referenced this issue Feb 19, 2021
@elpaso @nyalldawson
Fix vertex editor locale with Z/R values
00ffdc5 
Fixes qgis#29682

Manual backport of master commit e859d44
nyalldawson pushed a commit that referenced this issue Feb 19, 2021
@elpaso @nyalldawson
Fix vertex editor locale with Z/R values
bbe476a 
Fixes #29682

Manual backport of master commit e859d44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elpaso elpaso

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality
Projects
None yet
Milestone
No milestone
6 participants
@elpaso @gioman @SrNetoChan @Xeenych @qgib @EcoMiksi