Default layout manager templates not working

[m-kuhn]

In the layout manager, there is a button "Open template directory -> Default".

This button points to a system directory (pkgDataPath/composer_templates) that is not created by the QGIS installation. If the button is clicked, an error message appears, that the directory does not exist and cannot be created.

I am not sure if this is a leftover (and nowhere used) or if it is intended to deploy organization-wide templates.

• In the first case, it would be better to remove the button
• In the second case, it would be better to
  • improve the error message and point to the documentation section on how to setup things properly
  • and/or move this to a different folder which is managed by the sysadmin (and not the application installation)

@nyalldawson I think you originally implemented this behavior, I'd be glad if you could shed some light

[nyalldawson]

@m-kuhn I didn't add this, so I'm not sure what the background to it is sorry.

I'd say for the "default" button we should either open the first folder specified under settings for layout templates, or if there's NONE, then disable the button.

[m-kuhn]

I see, git blame didn't show the real origin because layouts is a copy of composer, it has its original roots here:
f41489a

@mhugent do you know if this is still in use somewhere and what's your opinion about the proposed change long term?

I am afraid of breaking workflows by doing this change now. Would you be ok with the following proposal

1. If the pkgDataPath/ folder exists, open it
2. If the pkgDataPath/composer_templates folder does not exist, but a first setting exists, open it
3. If none of the folders exist, disable the button and set a tooltip pointing to settings
4. Add a TODO for QGIS 4 to turn off the pkgDataPath behavior