Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world_map.gpkg is changed everytime QGIS is run from build directory #31796

Closed
m-kuhn opened this issue Sep 16, 2019 · 9 comments · Fixed by #32122
Closed

world_map.gpkg is changed everytime QGIS is run from build directory #31796

m-kuhn opened this issue Sep 16, 2019 · 9 comments · Fixed by #32122
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@m-kuhn
Copy link
Member

m-kuhn commented Sep 16, 2019

This results in changes being reported in the local source directory and eventually clutters the commit history.

One way of solving this would be to focus on #23991
But since this is probably a tough one to solve, I could imagine an alternative solution like copying the file to the build directory.

@m-kuhn m-kuhn added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Sep 16, 2019
@nirvn
Copy link
Contributor

nirvn commented Sep 17, 2019

Another way would be to pick a different file format, ala zipped shapefiles/geojson/etc.

@m-kuhn
Copy link
Member Author

m-kuhn commented Sep 17, 2019

GeoJSON wouldn't be my favorite one for lack of spatial indexing, Shapefile/shz not for cropped attribute names.
Is it possible to zip a geopackage?
Let's hope @shapefile doesn't read this.

@Gustry
Copy link
Contributor

Gustry commented Sep 18, 2019

In the meantime, can we add a "hack" in the prepare commit hook script like git checkout path?

From @jef-n git update-index --assume-unchanged resources/data/world_map.gpkg, this works well.

@m-kuhn
Copy link
Member Author

m-kuhn commented Sep 18, 2019

Or add it to .gitignore

@jef-n
Copy link
Member

jef-n commented Sep 18, 2019

Or add it to .gitignore

doesn't work for files in the repository

@strk
Copy link
Contributor

strk commented Sep 24, 2019

This is a duplicate of #25830

@m-kuhn
Copy link
Member Author

m-kuhn commented Sep 24, 2019

Nope, this is also introduced without make check by simply running QGIS

@strk
Copy link
Contributor

strk commented Oct 3, 2019

Isn't this an issue even when calling qgis from system path ? I guess a system-installed world_map.gpkg file would be changed in that case ? Or how's that prevented (I dubt a user can change a system-installed file)

@strk
Copy link
Contributor

strk commented Jun 10, 2022

For the record: gpkg files created by GDAL < 3.3.1 are still modified -- the world_map.gpkg is one of those, see #48937 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants