Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information tab in WMS layer properties is unresponsive if a WMS service contains many layers #32213

Closed
andreasneumann opened this issue Oct 11, 2019 · 3 comments · Fixed by #32269
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@andreasneumann
Copy link
Member

Issue
When a WMS service contains many layers and the user opens the layer properties, QGIS becomes unresponsive for a while:

  • Opening the layer properties takes quite a long time (often several seconds)
  • Esp. opening the "Information" tab of the WMS layer takes very long (several seconds, up to a minute)

How to Reproduce

Here is a WMS service with many layers for testing:
https://geo.so.ch/api/wms

You can pick any layer, all have the same "unresponsiveness". e.g. you can pick "ch.so.arp.wanderwege"

QGIS and OS versions

Tested with Master, 3.4 and 3.8 on both Linux and Windows

@andreasneumann andreasneumann added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Oct 11, 2019
@andreasneumann andreasneumann changed the title Information tab in WMS layer properties are unresponsive if a WMS service contains many layers Information tab in WMS layer properties is unresponsive if a WMS service contains many layers Oct 11, 2019
@elpaso elpaso self-assigned this Oct 15, 2019
@elpaso
Copy link
Contributor

elpaso commented Oct 15, 2019

@andreasneumann I'm working on it and the main reason for this slowness is that there is a huge amount of HTML that is being constructed but the good new is that there are a few improvements I can make that will make it much faster.

@andreasneumann
Copy link
Member Author

@elpaso Thanks. If you already know what to do to fix this issue, then please go ahead and do it under the general bug fixing effort. Otherwise I would assign our support contract company to have a look at it.
Yes - the HTML in the information tab is - huge - for large WMS services.

@elpaso
Copy link
Contributor

elpaso commented Oct 15, 2019

Yes, I already have a patch that definitely fixes the issue but I need to fix some minor cosmetic aspects.

elpaso added a commit to elpaso/QGIS that referenced this issue Oct 16, 2019
@elpaso elpaso added Merge After Thaw For approved PRs which are ready to be merged as soon as master is thawed and removed Merge After Thaw For approved PRs which are ready to be merged as soon as master is thawed labels Oct 23, 2019
nyalldawson pushed a commit that referenced this issue Oct 25, 2019
backporting bot pushed a commit that referenced this issue Oct 25, 2019
nyalldawson pushed a commit that referenced this issue Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants