Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no value in the attribute form if value missing in the value map #32756

Closed
j-lippmann opened this issue Nov 9, 2019 · 21 comments · Fixed by #36804
Closed

no value in the attribute form if value missing in the value map #32756

j-lippmann opened this issue Nov 9, 2019 · 21 comments · Fixed by #36804
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Forms

Comments

@j-lippmann
Copy link

j-lippmann commented Nov 9, 2019

hello
If there a value in an attribute table datafield which is not in value map, then the value not visible in the attribute form if i click the feature with the info tool.

tested with qgis 3.11 an 3.4

value_map

@j-lippmann j-lippmann added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Nov 9, 2019
@j-lippmann j-lippmann changed the title no value in the attribut from if value missing in the value map no value in the attribute form if value missing in the value map Nov 9, 2019
@elpaso
Copy link
Contributor

elpaso commented Nov 11, 2019

I might be wrong but I think it's designed this way.
If the value is not in the map I guess it's not a valid value.
@m-kuhn what do you think?

@gioman
Copy link
Contributor

gioman commented Nov 11, 2019

If the value is not in the map I guess it's not a valid value.

the values that are not in the value map are supposed to show between parentheses. In my 3.4 installation it works are expected.

@m-kuhn
Copy link
Member

m-kuhn commented Nov 11, 2019

Other widgets (e.g. relation reference) show (value) in this case to make sure data is not lost.

@gioman
Copy link
Contributor

gioman commented Nov 11, 2019

@j-lippmann @elpaso

Screenshot_20191111_091043

@gioman gioman added the Feedback Waiting on the submitter for answers label Nov 11, 2019
@elpaso
Copy link
Contributor

elpaso commented Nov 11, 2019

Anyway, is this a regression? I think it's always been working (or broken) like that.

@gioman
Copy link
Contributor

gioman commented Nov 11, 2019

Anyway, is this a regression?

I haven't tested master, but on the latest 3.4 works as expected.

@m-kuhn
Copy link
Member

m-kuhn commented Nov 11, 2019

@gioman did you test the attribute form too (the screenshot shows the attribute table)?

@gioman
Copy link
Contributor

gioman commented Nov 11, 2019

@gioman did you test the attribute form too (the screenshot shows the attribute table)?

@m-kuhn you were right, in the feature form (both from identify or table) the value is not shown. Regression?

@m-kuhn
Copy link
Member

m-kuhn commented Nov 11, 2019

Regression?

I don't think so. But annoying anyway.

@gioman gioman added High Priority and removed Feedback Waiting on the submitter for answers labels Nov 11, 2019
@elpaso elpaso self-assigned this May 28, 2020
elpaso added a commit to elpaso/QGIS that referenced this issue May 28, 2020
@j-lippmann
Copy link
Author

j-lippmann commented Jun 7, 2020

hello @elpaso
thanks for fixing this issue. but my test result is that the problem is still present with the codeversion below. do i have the correct version?

QGIS-Version 3.13.0-Master QGIS-Codeversion ce17f7f
Kompiliert gegen Qt 5.11.2 Laufendes Qt 5.11.2
Kompiliert mit GDAL/OGR 3.2.0dev Läuft mit GDAL/OGR 3.2.0dev
Kompiliert mit GEOS 3.8.1-CAPI-1.13.3 Läuft mit GEOS 3.8.1-CAPI-1.13.3
Kompiliert mit SQLite 3.29.0 Läuft mit SQLite 3.29.0
PostgreSQL-Client-Version 11.5 SpatiaLite-Version 4.3.0
QWT-Version 6.1.3 QScintilla2-Version 2.10.8
Kompiliert mit PROJ 7.1.0 Läuft mit PROJ Rel. 7.1.0, August 1st, 2020
BS-Version Windows 7 SP 1 (6.1) Diese QGIS-Kopie schreibt Debugausgaben.
Aktive Python-Erweiterungen alkisplugin; AnotherDXF2Shape; clipper; DbgBaum; DbgGruen; go2mapillary; nominatim_locator_filter; qfieldsync; SaxonyCadastralParcels; splitmultipart; db_manager; processing

@j-lippmann
Copy link
Author

Update: if i turn edit mode on, i can use the "picklist" and i can see/use the missed value in the value map. but the missed value do not appear in the attribute form , if the edit mode is off.
mssql_snapping_test
mssql_snapping_test_edit

@elpaso
Copy link
Contributor

elpaso commented Jun 7, 2020

I might have checked and fixed the editable scenario only. I'll check the read only.

@elpaso elpaso reopened this Jun 7, 2020
@elpaso
Copy link
Contributor

elpaso commented Jun 8, 2020

@j-lippmann I just tested on master with a layer that is not editable and I cannot reproduce the issue.

Screenshot_20200608_084315

Can you please attach project and data so that I can test exactly your scenario?

elpaso added a commit to elpaso/QGIS that referenced this issue Jun 8, 2020
Corner case of bug qgis#32756, handles (NULL) value
when NULL is not in the map of allowed values.

NULL is shown as (NULL) instead of <NULL> in this case.
@elpaso
Copy link
Contributor

elpaso commented Jun 8, 2020

@j-lippmann I've just noticed that NULL was not handled correctly, I've added a few lines of code to handle that case in #37031

@elpaso
Copy link
Contributor

elpaso commented Jun 10, 2020

@j-lippmann can you please check latest master and check if you can still reproduce the issue?

@j-lippmann
Copy link
Author

@elpaso the issue is still present with this master:

e81af2c9e1

QGIS-Version
3.13.0-Master
QGIS-Codeversion
e81af2c
Kompiliert gegen Qt
5.11.2
Laufendes Qt
5.11.2
Kompiliert mit GDAL/OGR
3.2.0dev
Läuft mit GDAL/OGR
3.2.0dev
Kompiliert mit GEOS
3.8.1-CAPI-1.13.3
Läuft mit GEOS
3.8.1-CAPI-1.13.3
Kompiliert mit SQLite
3.29.0
Läuft mit SQLite
3.29.0
PostgreSQL-Client-Version
11.5
SpatiaLite-Version
4.3.0
QWT-Version
6.1.3
QScintilla2-Version
2.10.8
Kompiliert mit PROJ
7.1.0
Läuft mit PROJ
Rel. 7.1.0, August 1st, 2020
BS-Version
Windows 7 SP 1 (6.1)
Diese QGIS-Kopie schreibt Debugausgaben.
Aktive Python-Erweiterungen
alkisplugin;
AnotherDXF2Shape;
clipper;
DbgBaum;
DbgGruen;
go2mapillary;
nominatim_locator_filter;
qfieldsync;
qgis-maptiler-plugin;
SaxonyCadastralParcels;
splitmultipart;
db_manager;
processing

@elpaso elpaso removed their assignment Jun 11, 2020
@elpaso
Copy link
Contributor

elpaso commented Jun 11, 2020

I tested again and I cannot reproduce the issue on my dataset.

@j-lippmann
Copy link
Author

hello @elpaso
do i have the correct code version?:

QGIS-Version
3.13.0-Master
QGIS-Codeversion
e81af2c

i have attached my little qgis testproject (qgis-project is inside of the gpkg). it would be kind, if you could test with this project.
thank you very much

value_list.zip

@gioman
Copy link
Contributor

gioman commented Jun 12, 2020

I tested again and I cannot reproduce the issue on my dataset.

@elpaso I just tested with @j-lippmann sample project (and also with one of mine) and I confirm that in the edit form a value that is not in the value map does not show by default in the combobox/dropdown:

value in the value map

Screenshot_20200612_124813

value not in the value map

Screenshot_20200612_124830

qgis master revision f8d2951c3d

@Pedro-Murteira
Copy link

@j-lippmann It appears to be working as expected on QGIS 3.22.3. Did you come across this issue more recently?

@gioman gioman added Feedback Waiting on the submitter for answers Forms and removed High Priority labels Jan 19, 2022
@j-lippmann
Copy link
Author

@j-lippmann It appears to be working as expected on QGIS 3.22.3. Did you come across this issue more recently?

No. I have tested today with 3.22.3 and it works as expected. No more issue...cool! Thanks

@gioman gioman closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Forms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants