Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label letter and word spacing broken in QGIS 3.10 #32825

Closed
Xeenych opened this issue Nov 13, 2019 · 7 comments · Fixed by #32917
Closed

Label letter and word spacing broken in QGIS 3.10 #32825

Xeenych opened this issue Nov 13, 2019 · 7 comments · Fixed by #32917
Assignees
@nyalldawson
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Labeling Related to QGIS map labeling

Comments

@Xeenych
Copy link

Xeenych commented Nov 13, 2019 •
edited

Looks like introduction of kerning in 3.10 has broken letter and word spacing in labels.

In QGIS 3.10 if letter rspacing is set to something other than 0, then letter's interval shrinks or expands depending on zoom level.
Label size is set to map units.
Map projection is EPSG;3857
Layer projection id EPSG:3857

The attached gif-video shows difference in v3.4 and v3.10
https://yadi.sk/d/A4GRvsg6AJgG8A

Also notice, that in 3.4 the label is shown even if it is partially visible, but in 3.10 it disappears.
"Allow truncated labels" option is enabled in both projects
@Xeenych Xeenych added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Nov 13, 2019
@gioman gioman added the Labeling Related to QGIS map labeling label Nov 14, 2019
@gioman
Copy link
Contributor

gioman commented Nov 14, 2019

Also notice, that in 3.4 the label is shown even if it is partially visible, but in 3.10 it disappears.
"Allow truncted labels" option is enabled in both projects

@Xeenych Please file a separate ticket for this.

@Xeenych Xeenych mentioned this issue Nov 14, 2019
Closed
@gioman
Copy link
Contributor

gioman commented Nov 14, 2019

Looks like introduction of kerning in 3.10 has broken letter and word spacing in labels.

@nyalldawson is this confirmed/already reported?

@nyalldawson
Copy link
Collaborator

No, I can't confirm -- all working correctly here and in the (many) unit tests. We'll need a project which demonstrates this issue to reproduce.

@nyalldawson nyalldawson added the Feedback Waiting on the submitter for answers label Nov 14, 2019
@Xeenych
Copy link
Author

Xeenych commented Nov 15, 2019 •
edited

Here is the project
test.zip
video
https://yadi.sk/d/8mBlrAOI2LOhXQ

@andreasneumann
Copy link
Member

Ok - the question is:
what units are the letter and word spacing in?

I don't have a unit choice for those properties.

@nyalldawson : can we really assume that letter and word spacing inherits the units from the label size property? If yes, then I agree that this is broken. If not, then it would be useful being able to set units for these properties.

@Xeenych
Copy link
Author

Xeenych commented Nov 15, 2019 •
edited

In QGIS 3.4 it was assumed that letter spacing and font size units are the same. Both settings were in the same section. And letter spacing setting behave properly

@nyalldawson nyalldawson self-assigned this Nov 18, 2019
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Nov 18, 2019
@nyalldawson
[labeling] Fix evalution of letter/word spacing when font size is map…
9dd1721 
… units

Fixes qgis#32825
@nyalldawson nyalldawson mentioned this issue Nov 18, 2019
Merged
nyalldawson added a commit that referenced this issue Nov 19, 2019
@nyalldawson
[labeling] Fix evalution of letter/word spacing when font size is map…
0d6599a 
… units

Fixes #32825
@Xeenych
Copy link
Author

Xeenych commented Nov 20, 2019

What version number this fix will be available at?

nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Nov 21, 2019
@nyalldawson
[labeling] Fix evalution of letter/word spacing when font size is map…
a2c369d 
… units

Fixes qgis#32825

(cherry picked from commit 0d6599a)
nyalldawson added a commit that referenced this issue Nov 21, 2019
@nyalldawson
[labeling] Fix evalution of letter/word spacing when font size is map…
4e18d91 
… units

Fixes #32825

(cherry picked from commit 0d6599a)
@RyanTG RyanTG mentioned this issue Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nyalldawson nyalldawson

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Labeling Related to QGIS map labeling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix evalution of letter/word spacing when font size is map units nyalldawson/QGIS
4 participants
@andreasneumann @nyalldawson @gioman @Xeenych