Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QgsVectorLayer readStyle does not read scale based visibility #33840

Closed
Djedouas opened this issue Jan 16, 2020 · 1 comment · Fixed by #33987
Closed

QgsVectorLayer readStyle does not read scale based visibility #33840

Djedouas opened this issue Jan 16, 2020 · 1 comment · Fixed by #33987
Assignees
@elpaso
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@Djedouas
Copy link
Member

QgsVectorLayer::readStyle in Rendering category does not read scale based visibility setting.

Steps to reproduce:

  • run attached pyqgis file (contains QML style data)
    • reads a QML style string
    • creates and loads a memory layer
    • read the style into the QgsVectorLayer
  • open the created layer properties
  • see that the Scale based visibility setting in the Rendering section has not been set
@gioman gioman added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jan 16, 2020
@elpaso elpaso self-assigned this Jan 22, 2020
elpaso added a commit to elpaso/QGIS that referenced this issue Jan 22, 2020
@elpaso
Fix scale visibility in style read/write
28ce3cd 
Fixes qgis#33840
@elpaso elpaso mentioned this issue Jan 22, 2020
Merged
@elpaso
Copy link
Contributor

elpaso commented Jan 22, 2020

@Djedouas thank you for the test script: it was very helpful to identify the source of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elpaso elpaso

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scale visibility in style read/write elpaso/QGIS
3 participants
@elpaso @gioman @Djedouas