Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer Properties Information tab - formatting problems #33862

Closed
i-s-o opened this issue Jan 16, 2020 · 6 comments
Closed

Layer Properties Information tab - formatting problems #33862

i-s-o opened this issue Jan 16, 2020 · 6 comments

Comments

@i-s-o
Copy link
Contributor

@i-s-o i-s-o commented Jan 16, 2020

In the Layer Properties/Information dialog (QGIS 3.10 and 3.11, Windows 10),

  • CRS information is cut off
  • Can't copy the full CRS string (related to item above)
  • As the dialog is resized, labels column wraps too early (see pic)
  • Text is too big (in my opinion)

image

Compare this to QGIS 3.4
image

How to Reproduce

  1. Download one of U.S. NOAA's RNCs (geo-referenced charts) in BSB format. I used this one.
  2. Unzip.
  3. Drag/drop the file 12323_1.KAP onto QGIS from the appropriate sub directory.
  4. Double-click the layer in the Layers panel.
  5. Click on the Information tab on the left.

Additional context
For this specific file, I can go to Settings > Custom Projections > Format: WKT to get the full string, but it would be nicer if I can see (and copy) the string in the Properties dialog.

@i-s-o i-s-o added the Bug label Jan 16, 2020
@gioman gioman added the GUI/UX label Jan 16, 2020
@elpaso elpaso self-assigned this Jan 21, 2020
@elpaso

This comment has been minimized.

Copy link
Contributor

@elpaso elpaso commented Jan 21, 2020

@nyalldawson what's the reason for cutting CRS definition at 50 chars?

elpaso added a commit to elpaso/QGIS that referenced this issue Jan 21, 2020
... also makes first cell column a bit larger

Fixes qgis#33862 (partial fix)
@elpaso

This comment has been minimized.

Copy link
Contributor

@elpaso elpaso commented Jan 21, 2020

@i-s-o I've made a few small adjustments to the look and feel only, mind giving them a test run when the build is done?

@i-s-o

This comment has been minimized.

Copy link
Contributor Author

@i-s-o i-s-o commented Jan 22, 2020

Sorry for responding late, I didn't have access to my dev-VM: I was only able to compile overnight.

The dialog looks much better now:
image

Using 80% for the font size and a few more tweaks shown below make it even better in my opinion :). I haven't tested how these tweaks work on other platforms or other providers.
image

--- a/src/core/qgsapplication.cpp
+++ b/src/core/qgsapplication.cpp
@@ -1434,20 +1434,19 @@ QString QgsApplication::reportStyleSheet( QgsApplication::StyleSheetType styleSh
                    "}"
                    "table.tabular-view, table.list-view { "
                    "   border-collapse: collapse;"
-                   "   table-layout:fixed;"
                    "   width: 100% !important;"
+                   "   font-size: 80%;"
                    "}"
                    // Override
                    "h1 { "
                    "   line-height: inherit;"
                    "}"
                    "td, th {"
-                   "   word-wrap: break-word; "
                    "   vertical-align: top;"
                    "}"
                    // Set first column width
                    ".list-view th:first-child, .list-view td:first-child {"
-                   "   width: 15%;"
+                   "   white-space: nowrap;"
                    "}"
                    ".list-view.highlight { "
                    "   padding-left: inherit; "
@elpaso

This comment has been minimized.

Copy link
Contributor

@elpaso elpaso commented Jan 22, 2020

@i-s-o your version also looks nice, can you make a PR?
Going to "actions" on your branch (top menu) you will also find a windows build that you can use for windows testing.

@i-s-o

This comment has been minimized.

Copy link
Contributor Author

@i-s-o i-s-o commented Jan 22, 2020

Ok, I will submit a PR later tonight.

@nyalldawson nyalldawson reopened this Feb 3, 2020
@nyalldawson

This comment has been minimized.

Copy link
Contributor

@nyalldawson nyalldawson commented Feb 3, 2020

Custom CRS truncation is still an open issue

@nyalldawson nyalldawson self-assigned this Feb 3, 2020
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 3, 2020
nyalldawson added a commit that referenced this issue Feb 3, 2020
elpaso added a commit to elpaso/QGIS that referenced this issue Feb 5, 2020
... also makes first cell column a bit larger

Fixes qgis#33862 (partial fix)
nyalldawson added a commit that referenced this issue Feb 5, 2020
... also makes first cell column a bit larger

Fixes #33862 (partial fix)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.