Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGIS master project XML is invalid #34218

Closed
elpaso opened this issue Feb 3, 2020 · 0 comments · Fixed by #34219
Closed

QGIS master project XML is invalid #34218

elpaso opened this issue Feb 3, 2020 · 0 comments · Fixed by #34219
Assignees
@elpaso
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Regression Something which used to work, but doesn't anymore

Comments

@elpaso
Copy link
Contributor

elpaso commented Feb 3, 2020

Describe the bug

the project .qgs XML file produced with default settings is invalid:

  File "project.qgs", line 417
    <Option name="decimal_separator" type="QChar" value=""/>
                                                        ^
XMLSyntaxError: Char 0x0 out of allowed range, line 417, column 62

How to Reproduce

Just create a simple project with a single layer (any provider).

The issue is in QgsBasicNumericFormat::setConfiguration

configuration.value( QStringLiteral( "decimal_separator" ), QChar()

QChar default to 0x0 which is not a valid XML char.
@elpaso elpaso added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Regression Something which used to work, but doesn't anymore labels Feb 3, 2020
@elpaso elpaso self-assigned this Feb 3, 2020
elpaso added a commit to elpaso/QGIS that referenced this issue Feb 3, 2020
@elpaso
Do not insert 0x0 in XML
24f07e3 
Fixes qgis#34218
@elpaso elpaso mentioned this issue Feb 3, 2020
Merged
nyalldawson pushed a commit that referenced this issue Feb 3, 2020
@elpaso @nyalldawson
Do not insert 0x0 in XML
d06f2d8 
Fixes #34218
elpaso added a commit to elpaso/QGIS that referenced this issue Feb 5, 2020
@elpaso
Do not insert 0x0 in XML
d27d8a0 
Fixes qgis#34218
@elpaso elpaso mentioned this issue Feb 5, 2020
Merged
nyalldawson pushed a commit that referenced this issue Feb 5, 2020
@elpaso @nyalldawson
Do not insert 0x0 in XML
282f90e 
Fixes #34218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elpaso elpaso

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Regression Something which used to work, but doesn't anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not insert 0x0 in XML elpaso/QGIS
1 participant
@elpaso