Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPKG transaction groups are stored with empty second pair of the key #36525

Closed
elpaso opened this issue May 18, 2020 · 0 comments · Fixed by #36677
Closed

GPKG transaction groups are stored with empty second pair of the key #36525

elpaso opened this issue May 18, 2020 · 0 comments · Fixed by #36677
Assignees
@elpaso
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@elpaso
Copy link
Contributor

elpaso commented May 18, 2020

in other words, the connection string is always an empty string and there is no way to use transaction groups when you have more than one GPKG in the same project.

That happens because QgsDataSourceUri( layer.source() ).connectionInfo() on a GPKG returns an empty string.

The sad reality is that QgsDataSourceUri is not appropriate anymore to handle all kind of data provider connections and URI encodings that we have.
@elpaso elpaso added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label May 18, 2020
@elpaso elpaso self-assigned this May 19, 2020
elpaso added a commit to elpaso/QGIS that referenced this issue May 22, 2020
@elpaso
Support OGR GPKG in datasource uri connection info
33708ea 
Makes QgsDataSourceUri::connectionInfo usable with
GPKG and OGR/Spatialite file-based DBs.

With tests.

Fixes qgis#36525
@elpaso elpaso mentioned this issue May 22, 2020
Closed
elpaso added a commit to elpaso/QGIS that referenced this issue May 23, 2020
@elpaso
Fix transaction groups on multiple GPKGs
c343af7 
Fixes qgis#36525
@elpaso elpaso mentioned this issue May 23, 2020
Merged
elpaso added a commit to elpaso/QGIS that referenced this issue Jun 12, 2020
@elpaso
[backport] Fix transaction groups on multiple GPKGs
e248626 
Fixes qgis#36525

Backport from master commit c343af7
nyalldawson pushed a commit to nyalldawson/QGIS that referenced this issue Jun 15, 2020
@elpaso @nyalldawson
[backport] Fix transaction groups on multiple GPKGs
768b23d 
Fixes qgis#36525

Backport from master commit c343af7

(cherry picked from commit e248626)
nyalldawson pushed a commit that referenced this issue Jun 19, 2020
@elpaso @nyalldawson
[backport] Fix transaction groups on multiple GPKGs
eceb7c3 
Fixes #36525

Backport from master commit c343af7

(cherry picked from commit e248626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elpaso elpaso

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
No milestone
1 participant
@elpaso