Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-edit is extremely slow #36863

Closed
gioman opened this issue Jun 1, 2020 · 6 comments
Closed

Multi-edit is extremely slow #36863

gioman opened this issue Jun 1, 2020 · 6 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Editing Feedback Waiting on the submitter for answers

Comments

@gioman
Copy link
Contributor

gioman commented Jun 1, 2020

This bug is particularly visible when using data from a remote (i.e. not local or local network) datasource.

When selecting features (even a few ones, even just one) and clicking on the multi-edit icon, the dialog takes a lot to come up to a point that if (just?) thousands of features are selected then QGIS basically freezes up (maybe not completely, just it does not return to life in a acceptable amount of time).

QGIS master on Linux and Windows.

On local datasources this problem is much less evident.

@rduivenvoorde
Copy link
Contributor

@gioman do you have some easy testing case? Happy to test #41382 with it

@gioman
Copy link
Contributor Author

gioman commented Feb 6, 2021

@gioman do you have some easy testing case? Happy to test #41382 with it

@rduivenvoorde it is pretty simple, on a remote postgis host (so the problem shows up clearly, mine are on hetzner for example) try multi-edit 5/50/500/5000 features. Thanks for testing the patch, I can't compile at home during the week end.

@rduivenvoorde
Copy link
Contributor

Yep, the number of features now do not determine the time it takes to shop up the dialog... Wait for this PR to land, but I think this issue can be closed then

@rduivenvoorde rduivenvoorde added the Feedback Waiting on the submitter for answers label Feb 6, 2021
@rduivenvoorde
Copy link
Contributor

adding feedback tag ;-)

@gioman
Copy link
Contributor Author

gioman commented Feb 7, 2021

Wait for this PR to land, but I think this issue can be closed then

@rduivenvoorde yes I tested the patch and this is fixed.

@gioman gioman closed this as completed Feb 7, 2021
@nyalldawson nyalldawson reopened this Feb 8, 2021
@nyalldawson
Copy link
Collaborator

Just re-opening till the pr is merged :)

nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 8, 2021
field) when the attribute form is opened.

This is incredibly expensive, yet only required in a very very small
corner case (field is from a joined layer without the upsert on edit
capabilities).

Refine logic to avoid the scan wherever we can.

Fixes qgis#41366
Fixes qgis#36863
github-actions bot pushed a commit that referenced this issue Feb 9, 2021
field) when the attribute form is opened.

This is incredibly expensive, yet only required in a very very small
corner case (field is from a joined layer without the upsert on edit
capabilities).

Refine logic to avoid the scan wherever we can.

Fixes #41366
Fixes #36863
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 16, 2021
field) when the attribute form is opened.

This is incredibly expensive, yet only required in a very very small
corner case (field is from a joined layer without the upsert on edit
capabilities).

Refine logic to avoid the scan wherever we can.

Fixes qgis#41366
Fixes qgis#36863

(cherry picked from commit c661359)
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 19, 2021
field) when the attribute form is opened.

This is incredibly expensive, yet only required in a very very small
corner case (field is from a joined layer without the upsert on edit
capabilities).

Refine logic to avoid the scan wherever we can.

Fixes qgis#41366
Fixes qgis#36863

(cherry picked from commit c661359)
nyalldawson added a commit that referenced this issue Feb 19, 2021
field) when the attribute form is opened.

This is incredibly expensive, yet only required in a very very small
corner case (field is from a joined layer without the upsert on edit
capabilities).

Refine logic to avoid the scan wherever we can.

Fixes #41366
Fixes #36863

(cherry picked from commit c661359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Editing Feedback Waiting on the submitter for answers
Projects
None yet
Development

No branches or pull requests

3 participants