Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point to Layer algorithm sets wrong output type #36941

Closed
spatialthoughts opened this issue Jun 3, 2020 · 1 comment · Fixed by #36946
Closed

Point to Layer algorithm sets wrong output type #36941

spatialthoughts opened this issue Jun 3, 2020 · 1 comment · Fixed by #36946
Assignees
@nyalldawson
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@spatialthoughts
Copy link
Contributor

Algorithn 'native:pointtolayer' is supposed to take a user input and turn it into a point layer. But the algorithm declares the output type to be a polygon. And thus when used in a model, certain algorithms (such as wedge buffers) do not see the output of pointtolayer as a valid input type.

src/analysis/processing/qgsalgorithmpointtolayer.cpp declares the output Feature Sink of type QgsProcessing::TypeVectorPolygon which should be ideally QgsProcessing::TypeVectorPoint
@spatialthoughts spatialthoughts added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jun 3, 2020
@spatialthoughts
Copy link
Contributor Author

See attached model (unzip file to use) where wedgebuffers algorithm doesn't take the output from pointtolayer.

wedge_buffer.model3.zip

@nyalldawson nyalldawson self-assigned this Jun 3, 2020
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jun 3, 2020
@nyalldawson
[processing] Set correct output layer type for Point to Layer algorithm
9a14f1a 
Fixes qgis#36941
@nyalldawson nyalldawson mentioned this issue Jun 3, 2020
Merged
nyalldawson added a commit that referenced this issue Jun 4, 2020
@nyalldawson
[processing] Set correct output layer type for Point to Layer algorithm
7ee85cd 
Fixes #36941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nyalldawson nyalldawson

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set correct output layer type for Point to Layer algorithm nyalldawson/QGIS
2 participants
@nyalldawson @spatialthoughts