Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of behaviour of Tessellate processing tool #37077

Closed
Dan-Eli opened this issue Jun 10, 2020 · 0 comments · Fixed by #37080
Closed

Change of behaviour of Tessellate processing tool #37077

Dan-Eli opened this issue Jun 10, 2020 · 0 comments · Fixed by #37080
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Regression Something which used to work, but doesn't anymore

Comments

@Dan-Eli
Copy link

Dan-Eli commented Jun 10, 2020

Feature description.

Starting from QGIS 3.10 there is a change in behaviour in the way the Tessellate processing tool is triangulating polygons.

The following figure is an example of tesssellation (triangulation) with QGIS version prior to 3.10 (3.8 and below)

image

The following figure is an example of tessellation with QGIS version 3.10 and over

image

While both version are valid polygon triangulation, the first one is more suited for shape analysis like extracting the Chordal axis (center line) of long any narrow polygons. Is the newer approach exploiting the probably easier and faster approach of fan triangulation, I don't know?

If the newer approach to tesselation is wanted/needed, could you please add a switch enabling to reproduce the older triangulation approach, for the ones who need that kind of triangulation. If it is not needed or wanted, bring back the old triangulation approach.

As you can see with the preceding description I do not know if I should tag this issue as bug or improvement... I will let you choose the right one

Additional context

The file included GeoPackage contains five layers. the layer named Polygons_v_3_12 contains the input polygons for the Tessellation. The other layers are the output of the tessellation for the following QGIS version: 3.4, 3.6, 3.8, 3.10 (3.12 is not included but it is the same has 3.10). A last observation, the new behaviour seems more to happen for long and narrow polygons that are either almost horizontal or almost vertical.

data_tessellate.zip

@nyalldawson nyalldawson self-assigned this Jun 10, 2020
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jun 10, 2020
geometry's aspect ratio

If we scale by an uneven amount in the x vs y plane, then the resultant
tesselation uses a misrepresentation of the actual shape of the geometry,
resulting in a poor quality tesselation.

Follow up 8ee1c20

Fixes qgis#37077
@nyalldawson nyalldawson added Bug Either a bug report, or a bug fix. Let's hope for the latter! Regression Something which used to work, but doesn't anymore and removed Feature Request labels Jun 10, 2020
nyalldawson added a commit that referenced this issue Jun 10, 2020
geometry's aspect ratio

If we scale by an uneven amount in the x vs y plane, then the resultant
tesselation uses a misrepresentation of the actual shape of the geometry,
resulting in a poor quality tesselation.

Follow up 8ee1c20

Fixes #37077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Regression Something which used to work, but doesn't anymore
Projects
None yet
2 participants