Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count of features is displayed only for the last selected layer of the layout legend #37194

Closed
DelazJ opened this issue Jun 14, 2020 · 4 comments · Fixed by #37213
Closed

Count of features is displayed only for the last selected layer of the layout legend #37194

DelazJ opened this issue Jun 14, 2020 · 4 comments · Fixed by #37213
Assignees
@nyalldawson
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@DelazJ
Copy link
Contributor

DelazJ commented Jun 14, 2020 •
edited

Layout legend items properties --> Layout items section
Select many layers and press the "show feature count" button
Only the last selected layer gets the count

nosumLegendItem

Actually afaics, the "move up"/"move down" as well as the "edit properties" tools behave the same: they are available when multiselection is done but only act on the last selected item.
@DelazJ DelazJ added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jun 14, 2020
@roya0045
Copy link
Contributor

Version?

@roya0045
Copy link
Contributor

It is present in 3.12.0

@DelazJ
Copy link
Contributor Author

DelazJ commented Jun 14, 2020 •
edited

I tried on master, a couple of days old (b23eadd)

@roya0045
Copy link
Contributor

Yeah most of those use
QModelIndex currentIndex = mItemTreeView->currentIndex();
QgsLayerTreeNode *currentNode = mItemTreeView->currentNode();

This seem to have always been the case.

@nyalldawson nyalldawson self-assigned this Jun 15, 2020
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jun 15, 2020
@nyalldawson
[layout] Make "show feature count" button apply to all selected indexes
1399ae3 
Fixes qgis#37194
@nyalldawson nyalldawson mentioned this issue Jun 15, 2020
Merged
nyalldawson added a commit that referenced this issue Jun 15, 2020
@nyalldawson
[layout] Make "show feature count" button apply to all selected indexes
671cebc 
Fixes #37194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nyalldawson nyalldawson

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make "show feature count" button apply to all selected indexes nyalldawson/QGIS
3 participants
@nyalldawson @DelazJ @roya0045