Temporal controller monthly time step uses 30 days instead of a month to loop #37829

RousseauLambertLP · 2020-07-15T11:48:02Z

How to Reproduce

Add a WMS layer with a monthly time step, for example you can use https://geo.weather.gc.ca/geomet?LAYER=CANSIPS.MEM.ETA_TT.10
In the layer panel, open the layer properties and open the temporal feature. Make sure the values are: Start date: 2013-05-01 00:00:00 / End date: 2018-10-01 00:00:00
Open the Temporal controller in the animated temporal navigation and hit the refresh button, then change time step to 1 month
Click the go to next frame button and you will see that it looks like it loops over 30 days instead of a full month. For the layer above here are some of the time steps I get: 2013-05-01 00:00:00, 2013-05-31 00:00:00, 2013-06-30 00:00:00, 2013-07-30 00:00:00, 2013-08-29 00:00:00, etc

QGIS and OS versions

QGIS version	3.15.0-Master	QGIS code revision	`2e2acf9`
Compiled against Qt	5.11.2	Running against Qt	5.11.2
Compiled against GDAL/OGR	3.2.0dev	Running against GDAL/OGR	3.2.0dev
Compiled against GEOS	3.8.1-CAPI-1.13.3	Running against GEOS	3.8.1-CAPI-1.13.3
Compiled against SQLite	3.29.0	Running against SQLite	3.29.0
PostgreSQL Client Version	11.5	SpatiaLite Version	4.3.0
QWT Version	6.1.3	QScintilla2 Version	2.10.8
Compiled against PROJ	7.2.0	Running against PROJ	Rel. 7.2.0, November 1st, 2020
OS Version	Windows 10 (10.0)	This copy of QGIS writes debugging output.
Active python plugins	openlayers_plugin; qgis2web; qgisnetworklogger; quick_map_services; tile_plus; db_manager; MetaSearch

Additional context

We have seen this behavior for every monthly time interval WMS layer we have tested in the tool, which result in layers not been displayed.

CC @tomkralidis

The text was updated successfully, but these errors were encountered:

rduivenvoorde · 2020-11-29T14:42:24Z

@RousseauLambertLP I'm thinking about having a look at @dminor 's pull request, but was wondering about some edge cases like:

what if somebody chooses 30th of januari, what will be the next timestep then (given februari only has 28 days)?
or more general 31th of a month (half of the months do not have a 31th day), what about that?
Do you have a good idea for those cases?
Like 'remember the actual number, but in months wich do not have a 31th day, take 30?
Or.. if there is not a 31th (or 30, 29th) day, take the 30days (average) for that step (but remember the actual date and use it if it is possible?
Or.. make it not possible to choose 'month' in case the date is 29,30 or 31?
Or.. just request 31th of february (and and let the server decide what to do: error out or sent an alternative?)
I tried to test the wms example you give, but apparently it has a problem as I receive errors all the time (non time related)?

Samweli · 2020-11-30T10:39:02Z

what if somebody chooses 30th of januari, what will be the next timestep then (given februari only has 28 days)?

@rduivenvoorde I think from user perceptive, the next timestep should default to the last day of the next month(for this case it ll be 28th February)

Currently, we pass the frame duration as a QgsInterval and use the average duration of a month or year during the animation, for instance, 30 days rather than a month. This makes it impossible to have an animation that displays on a particular day each month, as the day in the next month will change depending on the number of days in the previous month. This changes QgsTemporalNavigationObject to take the time step and time step unit as separate arguments. The settings in QgsTemporalUtils::exportAnimation are left unchanged, because in this case the user interface is already set up to use an interval. If the time step has a fractional value, the frame duration is calculated using a QgsInterval as before. If it has an integer value, the calculation uses QDateTime to advance by the specified time step instead. So a value of 1.5 months results in a frame duration of 45 days, but a value of 1 month will result in a duration that depends on the length of the current month. Fixes qgis#37829.

rduivenvoorde · 2021-01-06T10:02:41Z

@Samweli @nyalldawson are we sure this is to be closed? In my test here with the url of the original issuer:

https://geo.weather.gc.ca/geomet?LAYER=CANSIPS.MEM.ETA_TT.10

Things work initially great. You start on the first of the month and you step through all 'firsts' of the upcoming months.

But it get heary when you set the timestep to 1 day, go to some day (like the 23th), then change to 30 days, which will by QGIS converted to 1 month(!), and then (seeing "timestep 1 month") QGIS steps 30 days again?

Also: because of the code that tries to guess what I want (if I set 7 days, make it a week etc etc), QGIS makes it harde to actually SET the start/end of the timestep.

Would it not be better to let the user really decide in what kind of steps the controller is going (like: if I want it 7 days, do not make it a week or so?)

I do understand this is getting rather complex... so don't get me wrong :-(
(I tried to make a screencast.. but failed)

@RousseauLambertLP @dminor can you confirm?

Samweli · 2021-01-06T10:18:29Z

then change to 30 days, which will by QGIS converted to 1 month(!), and then (seeing "timestep 1 month") QGIS steps 30 days again?

@rduivenvoorde I confirm this on master and QGIS 3.16

are we sure this is to be closed?

I think this is closed, we may need to open another ticket to address the timestep setting issue.

rduivenvoorde · 2021-01-06T11:27:57Z

Sure? so 2 tickets?

one which is actually the same as this one? As we cannot use the geomet-service after some fiddling? Should we not keep this one?
one which addresses the 'guessing' behavior ( I think it is this: https://github.com/qgis/QGIS/blob/master/src/gui/qgstemporalcontrollerwidget.cpp#L541 ?)

Samweli · 2021-01-06T16:46:17Z

so 2 tickets?

no , only one ticket.

one which addresses the 'guessing' behavior ( I think it is this

this is the only ticket that should be opened, a fix for this should also fix other problems as this issue is the root of the other misbehaviour.

Samweli · 2021-01-07T12:16:19Z

ping @rduivenvoorde

rduivenvoorde · 2021-01-07T12:51:20Z

@Samweli I created: #40871 yesterday
Though maybe not clear enough this is about the 'guessing' stuff?

Samweli · 2021-01-07T18:42:23Z

I see @rduivenvoorde, but I think #40871 is about another issue, let me open a ticket about the 'guessing' stuff.

Samweli · 2021-01-07T18:52:31Z

@rduivenvoorde see #40894

rduivenvoorde · 2021-02-12T09:56:15Z

@RousseauLambertLP can you please test. I think this one can be closed.

github-actions · 2021-02-27T02:01:40Z

The QGIS project highly values your report and would love to see it addressed. However, this issue has been left in feedback mode for the last 14 days and is being automatically marked as "stale".
If you would like to continue with this issue, please provide any missing information or answer any open questions. If you could resolve the issue yourself meanwhile, please leave a note for future readers with the same problem and close the issue.
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this issue.
If there is no further activity on this issue, it will be closed in a week.

gioman · 2021-06-04T13:00:02Z

Closing for lack of feedback.

RousseauLambertLP · 2021-06-28T18:42:50Z

Sorry for not replying, I was in parental leave for the last 8 months.

I tested QGIS 3.20 temporal animation tool using https://geo.weather.gc.ca/geomet?LAYER=CANSIPS.MEM.ETA_TT.10 and the monthly time step (default time step for this WMS layer) and I see the correct behavior for this layer.
The layer loops on the months and not 30 days, which was the issue here.

Thanks all for this work!

RousseauLambertLP added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jul 15, 2020

gioman added the Temporal Temporal filtering or animation label Jul 15, 2020

dminor mentioned this issue Jul 23, 2020

Pass time step and time step unit into QgsTemporalNavigationObject #37951

Closed

nyalldawson closed this as completed in 9da580c Jan 6, 2021

rduivenvoorde reopened this Jan 6, 2021

rduivenvoorde mentioned this issue Jan 7, 2021

Temporal controller widget skips to end of Range when switching UP in units(ize) #40871

Closed

Samweli mentioned this issue Jan 7, 2021

Temporal controller widget overwrite timestep and timestep unit for some input values. #40894

Closed

rduivenvoorde added the Feedback Waiting on the submitter for answers label Feb 12, 2021

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 27, 2021

gioman closed this as completed Jun 4, 2021

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporal controller monthly time step uses 30 days instead of a month to loop #37829

Temporal controller monthly time step uses 30 days instead of a month to loop #37829

RousseauLambertLP commented Jul 15, 2020 •

edited

rduivenvoorde commented Nov 29, 2020 •

edited

Samweli commented Nov 30, 2020

rduivenvoorde commented Jan 6, 2021

Samweli commented Jan 6, 2021

rduivenvoorde commented Jan 6, 2021

Samweli commented Jan 6, 2021

Samweli commented Jan 7, 2021

rduivenvoorde commented Jan 7, 2021 •

edited

Samweli commented Jan 7, 2021 •

edited

Samweli commented Jan 7, 2021

rduivenvoorde commented Feb 12, 2021

github-actions bot commented Feb 27, 2021

gioman commented Jun 4, 2021

RousseauLambertLP commented Jun 28, 2021

Temporal controller monthly time step uses 30 days instead of a month to loop #37829

Temporal controller monthly time step uses 30 days instead of a month to loop #37829

Comments

RousseauLambertLP commented Jul 15, 2020 • edited

rduivenvoorde commented Nov 29, 2020 • edited

Samweli commented Nov 30, 2020

rduivenvoorde commented Jan 6, 2021

Samweli commented Jan 6, 2021

rduivenvoorde commented Jan 6, 2021

Samweli commented Jan 6, 2021

Samweli commented Jan 7, 2021

rduivenvoorde commented Jan 7, 2021 • edited

Samweli commented Jan 7, 2021 • edited

Samweli commented Jan 7, 2021

rduivenvoorde commented Feb 12, 2021

github-actions bot commented Feb 27, 2021

gioman commented Jun 4, 2021

RousseauLambertLP commented Jun 28, 2021

RousseauLambertLP commented Jul 15, 2020 •

edited

rduivenvoorde commented Nov 29, 2020 •

edited

rduivenvoorde commented Jan 7, 2021 •

edited

Samweli commented Jan 7, 2021 •

edited