-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling attribute table of a layer added with the "delimted text provider" is almost impossible #38068
Comments
I suspect it's related to the recent View Selection performance issue too |
Hi @gioman I cannot reproduce the issue. Can you provide me the CSV file? Edit: I tested with a 50k rows on 100 columns but a dummy file with just strings and ints. So maybe it's not representative. |
with or without the latest patch (the revert of the previous patch)?
sure: CRS of data is EPSG 32629. For some reason I just noticed that if the table is docked then it is usable (barely considered that it is really a small dataset), while not docked full screen is really unsable. I'm on master on Ubuntu 18.04. |
definitely not working fine here... let me test on other systems. |
@signedav adding that CSV as geometryless table (i.e. by d&d the csv on the canvas) results is a quick table, you must add it as delimited text (spatial) table to see the slow down. |
Thanks. I can reproduce on master. Haven't found the reason yet. |
I checked out the commit c6823d8 what is the last commit of the implementation that contained the reason for #38018 but the scrolling was fine (maybe sometimes minimal hickups - but master lags clearly) On master I imported the data to a geopackage - means I opened the delimited layer and dragged it into an existing geopackage: The scrolling was fine on this layer. Maybe that's a lead. But I don't know. |
Thanks to @nyalldawson live debugging section, it was found this is caused by 644a564 . 99% time is spent in QString::indexOf() |
…nd-of-line characters Fixes qgis#38068 The performance regression was introduced per commit 644a564 It resulted in quadratic performance in the size of the buffer for CSV files with Unix '\n' end of line character, due to scanning repeatedly for `\r`
…nd-of-line characters Fixes qgis#38068 The performance regression was introduced per commit 644a564 It resulted in quadratic performance in the size of the buffer for CSV files with Unix '\n' end of line character, due to scanning repeatedly for `\r` (cherry picked from commit a667844)
QGIS 3.14/master, Linux and Windows.
I added a delimited text layer from a 18k rows CSV (so not exactly a big dataset) and scrolling the table of attributes is basically impossible (way too slow, almost now moving, also causing freezes).
I tested the same CSV on 2.18 and it was almost fine (it works except for some hiccup).
The text was updated successfully, but these errors were encountered: