Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Vector Layer algorithm does not export both null and empty values #38105

Closed
uclaros opened this issue Aug 3, 2020 · 0 comments · Fixed by #46997
Closed

Split Vector Layer algorithm does not export both null and empty values #38105

uclaros opened this issue Aug 3, 2020 · 0 comments · Fixed by #46997
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@uclaros
Copy link
Contributor

uclaros commented Aug 3, 2020

Describe the bug
The Split Vector Layer algorithm exports both null and empty values to the same filename silently overwriting the former with the later.
This was unintentionally fixed in the couple of last versions when ported to c++ and added a regression by replacing the filename with an numeric id.
By fixing this regression, the empty/null bug was reintroduced, so this is technically a regression too

How to Reproduce
Use the Split vector layer algorithm and use a field that contains both null and empty string values.
A single file is created containing only null or empty values.
@uclaros uclaros added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Aug 3, 2020
@gioman gioman added the Processing Relating to QGIS Processing framework or individual Processing algorithms label Aug 3, 2020
@uclaros uclaros changed the title Split Vector Layer algorithm exports both null and empty values to same file Split Vector Layer algorithm does not export both null and empty values Aug 3, 2020
@alexbruy alexbruy mentioned this issue Jan 25, 2022
Merged
alexbruy added a commit that referenced this issue Jan 27, 2022
@alexbruy
Merge pull request #46997 from alexbruy/split-vector-null
d90bc87 
[processing] save NULL and empty values into different files in Split Vector Layer algorithm (fix #38105)
@alexbruy alexbruy mentioned this issue Jan 27, 2022
Merged
alexbruy added a commit that referenced this issue Jan 30, 2022
@alexbruy
Merge pull request #47030 from alexbruy/split-vector-backport
4d9f636 
[backport release-3_22][processing] save NULL and empty values into different files in Split Vector Layer algorithm (fix #38105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Milestone
No milestone
2 participants
@gioman @uclaros