Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Select by polygon' doesn't select anymore geometries with errors #38460

Closed
tjukanovt opened this issue Aug 26, 2020 · 5 comments · Fixed by #39379
Closed

'Select by polygon' doesn't select anymore geometries with errors #38460

tjukanovt opened this issue Aug 26, 2020 · 5 comments · Fixed by #39379
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map Tools Related to non-digitizing map tools Regression Something which used to work, but doesn't anymore

Comments

@tjukanovt
Copy link

Describe the bug
When trying to do a seleciton on a layer, not all features inside the drawn polygon are being selected.

How to Reproduce

  1. Add layer (mine is a polygon GeoPackage in EPSG:3879
  2. Click on 'Select features by area/polygon'
  3. Try to select features
  4. See error in the screenshot below

QGIS and OS versions
QGIS version 3.14.15-Pi running on Windows 10. No plug-ins installed in this fresh profile.

Additional context

Here's how it should work and how it works in 3.10:
select_310

Here's how it "works" in the latest 3.14:
select_314
@tjukanovt tjukanovt added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Aug 26, 2020
@gioman gioman added Map Tools Related to non-digitizing map tools Regression Something which used to work, but doesn't anymore labels Aug 26, 2020
@gioman
Copy link
Contributor

gioman commented Aug 26, 2020 

1. Add layer (mine is a polygon GeoPackage in EPSG:3879

@tjukanovt please attach your dataset

@gioman gioman added the Feedback Waiting on the submitter for answers label Aug 26, 2020
@tjukanovt
Copy link
Author

@gioman You can download that here: https://drive.google.com/file/d/1riNfISQb9xNXIfWjJITNgyeJC4gK4GpN/view?usp=sharing

@tjukanovt
Copy link
Author

Actually my guess at the moment is that it has something to do with invalid geometries.

@gioman
Copy link
Contributor

gioman commented Aug 27, 2020

Actually my guess at the moment is that it has something to do with invalid geometries.

@tjukanovt good catch, seems is really the case. Anyway is a regression.

@gioman gioman removed the Feedback Waiting on the submitter for answers label Aug 27, 2020
@gioman gioman changed the title 'Select by polygon' doesn't select all features 'Select by polygon' doesn't select anymore geometries with errors Aug 27, 2020
@tjukanovt
Copy link
Author

Thanks for changing the title to a more descriptive one. Just noticed that this appears also in the 3.12 LTR

@nyalldawson nyalldawson mentioned this issue Oct 15, 2020
Merged
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Oct 20, 2020
@nyalldawson
When selecting features via rect, ignore GEOS errors due to invalid
0d5f28a 
geometries and allow these features to be selected based on their
bounding boxes alone.

Fixes qgis#38460
nyalldawson added a commit that referenced this issue Oct 21, 2020
@nyalldawson
When selecting features via rect, ignore GEOS errors due to invalid
22c2c5a 
geometries and allow these features to be selected based on their
bounding boxes alone.

Fixes #38460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map Tools Related to non-digitizing map tools Regression Something which used to work, but doesn't anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow selection of invalid geometries nyalldawson/QGIS
2 participants
@gioman @tjukanovt