Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGIS freezes/crashes during check geometries #38983

Closed
DeadBranches opened this issue Sep 23, 2020 · 22 comments · Fixed by #43662
Closed

QGIS freezes/crashes during check geometries #38983

DeadBranches opened this issue Sep 23, 2020 · 22 comments · Fixed by #43662
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Geometry checker High Priority

Comments

@DeadBranches
Copy link

DeadBranches commented Sep 23, 2020

QGIS 3.14.16 hangs at 99% while using the "Check Geometries" feature in the Vector menu for the layer in the sample file. I've isolated the crash to the geometry validity option "duplicate nodes."

Other settings are all as default. The output is to a new layer.

Windows 10 Pro N 2004 19041.450 64-bit
AMD Ryzen 5 3600
32 GB Ram

https://drive.google.com/file/d/16n87F-FtCch3MBj13Bz5Y0DR6fKQ-mfG/view?usp=sharing

@DeadBranches DeadBranches changed the title QGIS 3.14.16 freezes during geometry QGIS 3.14.16 freezes during check geometry Sep 23, 2020
@gioman
Copy link
Contributor

gioman commented Sep 23, 2020

@SalvatoryMalamar what is the exact tool your are using, "geometry checker"?

@gioman gioman added Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Plugins labels Sep 23, 2020
@DeadBranches
Copy link
Author

Oops, sorry for not being clear about that. It's the check geometries tool in the Vector menu.

@gioman
Copy link
Contributor

gioman commented Sep 23, 2020

https://drive.google.com/file/d/16n87F-FtCch3MBj13Bz5Y0DR6fKQ-mfG/view?usp=sharing

@SalvatoryMalamar please open access to this sample dataset.

@DeadBranches
Copy link
Author

My apologies gioman. Thank you for following up on the bug report. I've set the sample data set so anyone with the link can view.

@gioman
Copy link
Contributor

gioman commented Sep 24, 2020

Finishes fine on QGIS 3.10 on Linux (looking for duplicates nodes).

@gioman
Copy link
Contributor

gioman commented Sep 24, 2020

On Windows/master it seems to choke at 100%, but maybe is "just" the typical Windows slowness in running anything.

@gioman
Copy link
Contributor

gioman commented Sep 24, 2020

On Windows/master it seems to choke at 100%, but maybe is "just" the typical Windows slowness in running anything.

still unfinished here, I guess we can say that on Windows does not work.

@gioman gioman changed the title QGIS 3.14.16 freezes during check geometry QGIS freezes during check geometries Sep 24, 2020
@gioman gioman removed the Feedback Waiting on the submitter for answers label Sep 24, 2020
@DeadBranches
Copy link
Author

Thank you for verifying the validity of this bug report for Windows and Linux gioman. I appreciate your efforts.

@roya0045
Copy link
Contributor

roya0045 commented Feb 7, 2021

Is it with the dataset only or it happens with any dataset on windows?

@plitvicer
Copy link

plitvicer commented Mar 5, 2021

Same here with different dataset. Shapefile and SQLite DB. Also testet sample dataset from @SalvatoryMalamar
Using QGIS 3.16.4, Windows 10 Pro, 16GB RAM

@gioman
Copy link
Contributor

gioman commented Mar 6, 2021

Same here with different dataset. Shapefile and SQLite DB

@plitvicer attach here your sample.

@lucbontemps
Copy link

I'm encountering the same problem.
My environment: W10 PRO, 16Gb RAM, QGis 3.16.3., CRS project EPSG:2169
I've made many tests. On a subset (about the half), it is running.
On he whole dataset, QGis crashes systematically.
Tried without "Duplicate nodes", or other functionnal variations, no changes.
Here is a sample.
Feel free to ask for further information on my context.
PARQUETS_V3.zip

@gioman
Copy link
Contributor

gioman commented Mar 9, 2021

Feel free to ask for further information on my context.

@lucbontemps crash confirmed also on 3.18 on Linux.

@gioman gioman changed the title QGIS freezes during check geometries QGIS freezes/crashes during check geometries Mar 9, 2021
@nyalldawson
Copy link
Collaborator

@gioman

crash confirmed also on 3.18 on Linux.

What's required to reproduce this? I tried with just the "duplicate nodes" check enabled and no crash here...

@gioman
Copy link
Contributor

gioman commented Mar 10, 2021

What's required to reproduce this? I tried with just the "duplicate nodes" check enabled and no crash here...

@nyalldawson it crashes towards the end

Peek 2021-03-10 09-53

@lucbontemps
Copy link

Tried again on most of the checkbox and any of the ones I'm using.
"Check for duplicates" makes QGis crashing.
This option is necessary and sufficient. Not the other ones.
I presume the problem is due to this function.

On the other hand QGis freezes when exporting the errors. Another topic?

@nyalldawson
Copy link
Collaborator

I still can't reproduce this. Maybe it was fixed in newer GEOS versions...

@lucbontemps
Copy link

Here is a video without and with "Check for duplicates".
Windows 10 Pro, QGis 3.16.

20210528_121829.mp4

@gioman
Copy link
Contributor

gioman commented May 28, 2021

Here is a video without and with "Check for duplicates".

@lucbontemps no crash here on 3.16 on WIndows (with our dataset) and both check duplicates or not.

@lucbontemps
Copy link

@gioman: could you try on the dataset previously sent (see above)?

@gioman
Copy link
Contributor

gioman commented May 28, 2021

@lucbontemps I used this:

PARQUETS_V3.zip

@DeadBranches
Copy link
Author

Thank you @nyalldawson for your excellent work on improving QGIS. And thank you to everyone else for your great contributions in clarifying the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Geometry checker High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants