Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edit in Place] count points in the polygon does not work #39807

Closed
pigreco opened this issue Nov 4, 2020 · 9 comments
Closed

[Edit in Place] count points in the polygon does not work #39807

pigreco opened this issue Nov 4, 2020 · 9 comments
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@pigreco
Copy link
Sponsor Contributor

pigreco commented Nov 4, 2020

The Count Points in Polygon algorithm works fine, but when used with Edit in Place it doesn't work, i.e. it doesn't add in the field with the count.

How to reproduce it:

  1. add two layers, one polygonal and one point;
  2. from the processing tools, activate Edit in place and start it;
  3. insert the polygon as the first layer and the points as the second;
  4. launch the algorithm;
  5. when opening the attribute table of the polygonal layer there is no field with the count.

OSGeo4W64 Win 10 64

Even with a clean profile it doesn't work!

image

RipGeo01012020_g.zip

@pigreco pigreco added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms labels Nov 4, 2020
@bellanz80
Copy link

I confirm, on QGIS 3.16 and 3.14.0,
Windows 10

@gioman gioman added the Feedback Waiting on the submitter for answers label Nov 4, 2020
@gioman
Copy link
Contributor

gioman commented Nov 4, 2020

@pigreco interesting, here on 3.16 there is no such tool when activating the "edit features in place" option

Screenshot_20201104_164522

@pigreco
Copy link
Sponsor Contributor Author

pigreco commented Nov 4, 2020

@gioman

@pigreco interesting, here on 3.16 there is no such tool when activating the "edit features in place" option

have you tried to select a polygonal layer?

@gioman
Copy link
Contributor

gioman commented Nov 4, 2020

have you tried to select a polygonal layer?

sorry you are right, I was sure i had it.

@pigreco
Copy link
Sponsor Contributor Author

pigreco commented Nov 5, 2020

@gioman

sorry you are right, I was sure i had it.

if you confirm it is a bug, please remove feedback

@SrNetoChan
Copy link
Member

Confirmed also on Ubuntu 18.04

@DelazJ DelazJ removed the Feedback Waiting on the submitter for answers label Nov 6, 2020
@uclaros
Copy link
Contributor

uclaros commented Nov 14, 2020

Is modifying the fields even supported by the current implementation of in place editing? Because if not, then the bug is that the algorithm is flagged as supporting in place edits while it shouldn't!

@agiudiceandrea
Copy link
Contributor

See also https://lists.osgeo.org/pipermail/qgis-user/2020-December/047426.html

@DelazJ
Copy link
Contributor

DelazJ commented Dec 8, 2020

Is modifying the fields even supported by the current implementation of in place editing? Because if not, then the bug is that the algorithm is flagged as supporting in place edits while it shouldn't!

According to what I read in the docs, it shouldn't be listed if it adds fields to the existing layer. Unless rules have changed and docs needs update.

@lbartoletti lbartoletti self-assigned this Feb 2, 2021
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 2, 2021
Sum Line Length and Count Points In Polygons result fields
when running in in-place mode

Makes these algorithms fully compatible with in place execution

Fixes qgis#39807
github-actions bot pushed a commit that referenced this issue Feb 3, 2021
Sum Line Length and Count Points In Polygons result fields
when running in in-place mode

Makes these algorithms fully compatible with in place execution

Fixes #39807
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 19, 2021
Sum Line Length and Count Points In Polygons result fields
when running in in-place mode

Makes these algorithms fully compatible with in place execution

Fixes qgis#39807

(cherry picked from commit 9297938)
nyalldawson added a commit that referenced this issue Feb 19, 2021
Sum Line Length and Count Points In Polygons result fields
when running in in-place mode

Makes these algorithms fully compatible with in place execution

Fixes #39807

(cherry picked from commit 9297938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
8 participants