Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layers removed from the layer tree are not removed from the project #40050

Closed
borysiasty opened this issue Nov 14, 2020 · 3 comments · Fixed by #40052
Closed

Layers removed from the layer tree are not removed from the project #40050

borysiasty opened this issue Nov 14, 2020 · 3 comments · Fixed by #40052
Assignees
@elpaso
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Project Regression Something which used to work, but doesn't anymore

Comments

@borysiasty
Copy link
Member

Removing layers in GUI doesn't remove them from the project document any more.

Steps to reproduce:

  1. Open an empty project
  2. Add any layer
  3. Remove it
  4. QgsProject.instance().mapLayers() still contain the layer!

I'm flagging a data corruption as it makes project files inconsistent.

@elpaso, I'm assigning it to you as it may be related to the recent changes in the layer tree, doesn't it?
@borysiasty borysiasty added Regression Something which used to work, but doesn't anymore Project Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption labels Nov 14, 2020
@gioman
Copy link
Contributor

gioman commented Nov 14, 2020

@borysiasty is this only on master?

@gioman gioman added the Feedback Waiting on the submitter for answers label Nov 14, 2020
@elpaso
Copy link
Contributor

elpaso commented Nov 14, 2020

Yes, a missing signal probably.

elpaso added a commit to elpaso/QGIS that referenced this issue Nov 14, 2020
@elpaso
Restore layer bridge
c9bba96 
Fixes qgis#40050
@elpaso elpaso mentioned this issue Nov 14, 2020
Merged
@borysiasty
Copy link
Member Author

@elpaso Works fine now, thanks!
@gioman yes. Sorry I forgot to write it :)

@borysiasty borysiasty removed the Feedback Waiting on the submitter for answers label Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elpaso elpaso

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Project Regression Something which used to work, but doesn't anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore layer bridge elpaso/QGIS
3 participants
@elpaso @borysiasty @gioman