Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QgsProcessingParameterFolderDestination default value issue in PointsToPath in the modeler #40486

Closed
roya0045 opened this issue Dec 7, 2020 · 1 comment · Fixed by #40488
Closed

QgsProcessingParameterFolderDestination default value issue in PointsToPath in the modeler #40486

roya0045 opened this issue Dec 7, 2020 · 1 comment · Fixed by #40488
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore

Comments

@roya0045
Copy link
Contributor

roya0045 commented Dec 7, 2020

This is a regression spotted in 3.16.1 that was not present in 3.16.0.

When running PointstoPath in the modeler the output_text_dir parameter has a default value that is the temporary output directoy + "OUTPUT_TEXT_DIR", I have no clue why the name of the parameter is added to the path of the temporary directory but now this ensure that the algorithm always fails due to the fact that the directory does not exist.

See

QGIS/python/plugins/processing/algs/qgis/PointsToPaths.py

Line 113 in ae565f1

text_dir = self.parameterAsString(parameters, self.OUTPUT_TEXT_DIR, context)
where a value magically appears in the modeler.

Will provide a bugfix as a temporary measure for this algorithm,
@roya0045 roya0045 added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Dec 7, 2020
@roya0045 roya0045 mentioned this issue Dec 7, 2020
Merged
@gioman gioman added Regression Something which used to work, but doesn't anymore Processing Relating to QGIS Processing framework or individual Processing algorithms labels Dec 8, 2020
@nyalldawson
Copy link
Collaborator

I can't reproduce this -- see below:

image

Can you share your model?

@nyalldawson nyalldawson added the Feedback Waiting on the submitter for answers label Dec 20, 2020
nyalldawson pushed a commit that referenced this issue Dec 22, 2020
@roya0045
[bugfix] PTP check for output folder. (#40488)
b686336 
Fixes #40486
nyalldawson pushed a commit to nyalldawson/QGIS that referenced this issue Jan 14, 2021
@roya0045 @nyalldawson
[bugfix] PTP check for output folder. (qgis#40488)
98b2e35 
Fixes qgis#40486

(cherry picked from commit b686336)
nyalldawson pushed a commit that referenced this issue Jan 15, 2021
@roya0045 @nyalldawson
[bugfix] PTP check for output folder. (#40488)
0a9f20f 
Fixes #40486

(cherry picked from commit b686336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bugfix] PTP check for output folder. roya0045/QGIS_1
3 participants
@nyalldawson @gioman @roya0045